From: yangguo@chromium.org Date: Fri, 22 Aug 2014 11:09:13 +0000 (+0000) Subject: Pacify GCmole. X-Git-Tag: upstream/4.7.83~7463 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2229575b261ee83efcc77197be910419adaf3d26;p=platform%2Fupstream%2Fv8.git Pacify GCmole. R=jarin@chromium.org Review URL: https://codereview.chromium.org/490423003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23300 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- diff --git a/test/cctest/test-dictionary.cc b/test/cctest/test-dictionary.cc index 9a19142..14e5d69 100644 --- a/test/cctest/test-dictionary.cc +++ b/test/cctest/test-dictionary.cc @@ -99,8 +99,8 @@ static void TestHashMap(Handle table) { for (int i = 0; i < 100; i++) { Handle key = factory->NewJSArray(7); CHECK_EQ(table->Lookup(key), CcTest::heap()->the_hole_value()); - CHECK_EQ(key->GetIdentityHash(), - CcTest::heap()->undefined_value()); + Object* identity_hash = key->GetIdentityHash(); + CHECK_EQ(identity_hash, CcTest::heap()->undefined_value()); } } diff --git a/test/cctest/test-ordered-hash-table.cc b/test/cctest/test-ordered-hash-table.cc index bb1e014..9578936 100644 --- a/test/cctest/test-ordered-hash-table.cc +++ b/test/cctest/test-ordered-hash-table.cc @@ -118,7 +118,8 @@ TEST(Map) { CHECK(ordered_map->Lookup(obj)->IsTheHole()); ordered_map = OrderedHashMap::Put(ordered_map, obj, val); CHECK_EQ(1, ordered_map->NumberOfElements()); - CHECK(ordered_map->Lookup(obj)->SameValue(*val)); + Object* lookup = ordered_map->Lookup(obj); + CHECK(lookup->SameValue(*val)); bool was_present = false; ordered_map = OrderedHashMap::Remove(ordered_map, obj, &was_present); CHECK(was_present); @@ -136,20 +137,28 @@ TEST(Map) { ordered_map = OrderedHashMap::Put(ordered_map, obj2, val2); ordered_map = OrderedHashMap::Put(ordered_map, obj3, val3); CHECK_EQ(3, ordered_map->NumberOfElements()); - CHECK(ordered_map->Lookup(obj1)->SameValue(*val1)); - CHECK(ordered_map->Lookup(obj2)->SameValue(*val2)); - CHECK(ordered_map->Lookup(obj3)->SameValue(*val3)); + lookup = ordered_map->Lookup(obj1); + CHECK(lookup->SameValue(*val1)); + lookup = ordered_map->Lookup(obj2); + CHECK(lookup->SameValue(*val2)); + lookup = ordered_map->Lookup(obj3); + CHECK(lookup->SameValue(*val3)); // Test growth ordered_map = OrderedHashMap::Put(ordered_map, obj, val); Handle obj4 = factory->NewJSObjectFromMap(map); Handle val4 = factory->NewJSObjectFromMap(map); ordered_map = OrderedHashMap::Put(ordered_map, obj4, val4); - CHECK(ordered_map->Lookup(obj)->SameValue(*val)); - CHECK(ordered_map->Lookup(obj1)->SameValue(*val1)); - CHECK(ordered_map->Lookup(obj2)->SameValue(*val2)); - CHECK(ordered_map->Lookup(obj3)->SameValue(*val3)); - CHECK(ordered_map->Lookup(obj4)->SameValue(*val4)); + lookup = ordered_map->Lookup(obj); + CHECK(lookup->SameValue(*val)); + lookup = ordered_map->Lookup(obj1); + CHECK(lookup->SameValue(*val1)); + lookup = ordered_map->Lookup(obj2); + CHECK(lookup->SameValue(*val2)); + lookup = ordered_map->Lookup(obj3); + CHECK(lookup->SameValue(*val3)); + lookup = ordered_map->Lookup(obj4); + CHECK(lookup->SameValue(*val4)); CHECK_EQ(5, ordered_map->NumberOfElements()); CHECK_EQ(4, ordered_map->NumberOfBuckets());