From: Nathan Huckleberry Date: Tue, 13 Sep 2022 20:55:27 +0000 (-0700) Subject: drm/i915: Fix return type of mode_valid function hook X-Git-Tag: v6.1-rc5~176^2~15^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=21f0b7dabf9c358e75a539b5554c0375bf1abe0a;p=platform%2Fkernel%2Flinux-starfive.git drm/i915: Fix return type of mode_valid function hook All of the functions used for intel_dvo_dev_ops.mode_valid have a return type of enum drm_mode_status, but the mode_valid field in the struct definition has a return type of int. The mismatched return type breaks forward edge kCFI since the underlying function definitions do not match the function hook definition. The return type of the mode_valid field should be changed from int to enum drm_mode_status. Reported-by: Dan Carpenter Link: https://github.com/ClangBuiltLinux/linux/issues/1703 Cc: llvm@lists.linux.dev Signed-off-by: Nathan Huckleberry Reviewed-by: Nathan Chancellor Reviewed-by: Andrzej Hajda Signed-off-by: Jani Nikula Link: https://patchwork.freedesktop.org/patch/msgid/20220913205531.155046-1-nhuck@google.com --- diff --git a/drivers/gpu/drm/i915/display/intel_dvo_dev.h b/drivers/gpu/drm/i915/display/intel_dvo_dev.h index d96c3cc46e50..50205f064d93 100644 --- a/drivers/gpu/drm/i915/display/intel_dvo_dev.h +++ b/drivers/gpu/drm/i915/display/intel_dvo_dev.h @@ -75,8 +75,8 @@ struct intel_dvo_dev_ops { * * \return MODE_OK if the mode is valid, or another MODE_* otherwise. */ - int (*mode_valid)(struct intel_dvo_device *dvo, - struct drm_display_mode *mode); + enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo, + struct drm_display_mode *mode); /* * Callback for preparing mode changes on an output