From: Samuel Iglesias Gonsalvez Date: Mon, 10 Dec 2012 10:50:04 +0000 (+0100) Subject: ipack/devices/ipoctal: ack IRQ before processing it X-Git-Tag: upstream/snapshot3+hdmi~5693^2~118 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=21d27ed4616c9a7f2886c4159b4c409f73f96e76;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git ipack/devices/ipoctal: ack IRQ before processing it Due to the IRQ processing, we can generate another IRQ that can come before we end the previous one, so we lost it. E.g. when transmitting a character. To allow the processing in SMP machines, we ack the IRQ at the beginning of the IRQ handler. Signed-off-by: Samuel Iglesias Gonsalvez Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/ipack/devices/ipoctal.c b/drivers/ipack/devices/ipoctal.c index 09e3a8e..9cd5572 100644 --- a/drivers/ipack/devices/ipoctal.c +++ b/drivers/ipack/devices/ipoctal.c @@ -223,14 +223,14 @@ static irqreturn_t ipoctal_irq_handler(void *arg) unsigned int i; struct ipoctal *ipoctal = (struct ipoctal *) arg; - /* Check all channels */ - for (i = 0; i < NR_CHANNELS; i++) - ipoctal_irq_channel(&ipoctal->channel[i]); - /* Clear the IPack device interrupt */ readw(ipoctal->int_space + ACK_INT_REQ0); readw(ipoctal->int_space + ACK_INT_REQ1); + /* Check all channels */ + for (i = 0; i < NR_CHANNELS; i++) + ipoctal_irq_channel(&ipoctal->channel[i]); + return IRQ_HANDLED; }