From: Askar Safin Date: Wed, 4 Sep 2019 09:54:17 +0000 (+0300) Subject: gst-player: fix bug with changing playback direction X-Git-Tag: 1.16.2~29 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=21ad51f48c651350b543d74e6373773bad54fd93;p=platform%2Fupstream%2Fgst-plugins-bad.git gst-player: fix bug with changing playback direction Fix gst_event_new_seek call in gst-libs/gst/player/gstplayer.c If rate >= 0.0, then previous code doesn't set end of segment. So, the end of segment will be in place where previous seek put it. This is not neccesary end of media file (in case of reverse playback). So if we play video backward for some time and then switched to forward playing, we will get EOS somewhere in the middle of media file. This commit always sets end of segment, thus fixing this bug --- diff --git a/gst-libs/gst/player/gstplayer.c b/gst-libs/gst/player/gstplayer.c index af9278aa7..259d11e5f 100644 --- a/gst-libs/gst/player/gstplayer.c +++ b/gst-libs/gst/player/gstplayer.c @@ -3357,7 +3357,7 @@ gst_player_seek_internal_locked (GstPlayer * self) if (rate >= 0.0) { s_event = gst_event_new_seek (rate, GST_FORMAT_TIME, flags, - GST_SEEK_TYPE_SET, position, GST_SEEK_TYPE_NONE, GST_CLOCK_TIME_NONE); + GST_SEEK_TYPE_SET, position, GST_SEEK_TYPE_SET, GST_CLOCK_TIME_NONE); } else { s_event = gst_event_new_seek (rate, GST_FORMAT_TIME, flags, GST_SEEK_TYPE_SET, G_GINT64_CONSTANT (0), GST_SEEK_TYPE_SET, position);