From: Krzysztof Kozlowski Date: Mon, 25 Oct 2021 14:49:36 +0000 (+0200) Subject: nfc: port100: fix using -ERRNO as command type mask X-Git-Tag: v5.15~16^2~20 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2195f2062e4cc93870da8e71c318ef98a1c51cef;p=platform%2Fkernel%2Flinux-starfive.git nfc: port100: fix using -ERRNO as command type mask During probing, the driver tries to get a list (mask) of supported command types in port100_get_command_type_mask() function. The value is u64 and 0 is treated as invalid mask (no commands supported). The function however returns also -ERRNO as u64 which will be interpret as valid command mask. Return 0 on every error case of port100_get_command_type_mask(), so the probing will stop. Cc: Fixes: 0347a6ab300a ("NFC: port100: Commands mechanism implementation") Signed-off-by: Krzysztof Kozlowski Signed-off-by: David S. Miller --- diff --git a/drivers/nfc/port100.c b/drivers/nfc/port100.c index 517376c..16ceb76 100644 --- a/drivers/nfc/port100.c +++ b/drivers/nfc/port100.c @@ -1006,11 +1006,11 @@ static u64 port100_get_command_type_mask(struct port100 *dev) skb = port100_alloc_skb(dev, 0); if (!skb) - return -ENOMEM; + return 0; resp = port100_send_cmd_sync(dev, PORT100_CMD_GET_COMMAND_TYPE, skb); if (IS_ERR(resp)) - return PTR_ERR(resp); + return 0; if (resp->len < 8) mask = 0;