From: Al Viro Date: Sun, 22 Sep 2013 18:33:32 +0000 (-0400) Subject: upstream: dmxdev: get rid of pointless clearing ->f_op X-Git-Tag: submit/tizen/20141121.110247~1811 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2174127f95e17189a426e3357d5a1eef659084ab;p=platform%2Fkernel%2Flinux-3.10.git upstream: dmxdev: get rid of pointless clearing ->f_op nobody else will see that struct file after return from ->release() anyway; just leave ->f_op as is and let __fput() do that fops_put(). Signed-off-by: Al Viro --- diff --git a/drivers/media/dvb-core/dmxdev.c b/drivers/media/dvb-core/dmxdev.c index 0b4616b..c0363f1 100644 --- a/drivers/media/dvb-core/dmxdev.c +++ b/drivers/media/dvb-core/dmxdev.c @@ -206,8 +206,6 @@ static int dvb_dvr_release(struct inode *inode, struct file *file) /* TODO */ dvbdev->users--; if (dvbdev->users == 1 && dmxdev->exit == 1) { - fops_put(file->f_op); - file->f_op = NULL; mutex_unlock(&dmxdev->mutex); wake_up(&dvbdev->wait_queue); } else @@ -1120,8 +1118,6 @@ static int dvb_demux_release(struct inode *inode, struct file *file) mutex_lock(&dmxdev->mutex); dmxdev->dvbdev->users--; if(dmxdev->dvbdev->users==1 && dmxdev->exit==1) { - fops_put(file->f_op); - file->f_op = NULL; mutex_unlock(&dmxdev->mutex); wake_up(&dmxdev->dvbdev->wait_queue); } else