From: Alexander Aring Date: Mon, 14 Apr 2014 16:48:02 +0000 (+0200) Subject: at86rf230: fix __at86rf230_read_subreg function X-Git-Tag: v4.9.8~6535^2~6 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2168746cfc075d004fd7044be706054fceb24e59;p=platform%2Fkernel%2Flinux-rpi3.git at86rf230: fix __at86rf230_read_subreg function The __at86rf230_read_subreg function don't mask and shift register contents which it should do. This patch adds the necessary masks and shift operations in this function. Since we have csma support this can make some trouble on state changes. Since CSMA support turned on some bits in the TRX_STATUS register that used to be zero, not masking broke checking of the TRX_STATUS field after commanding a state change. Signed-off-by: Alexander Aring Reviewed-by: Werner Almesberger Signed-off-by: David S. Miller --- diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c index e102eef..e36f194 100644 --- a/drivers/net/ieee802154/at86rf230.c +++ b/drivers/net/ieee802154/at86rf230.c @@ -365,7 +365,7 @@ __at86rf230_read_subreg(struct at86rf230_local *lp, dev_vdbg(&lp->spi->dev, "buf[1] = %02x\n", buf[1]); if (status == 0) - *data = buf[1]; + *data = (buf[1] & mask) >> shift; return status; }