From: WANG Cong <xiyou.wangcong@gmail.com>
Date: Sun, 18 Sep 2016 22:52:20 +0000 (-0700)
Subject: net_sched: check NULL on error path in route4_change()
X-Git-Tag: v4.9-rc1~127^2~91
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=21641c2e1ffd0b504610a33beaeab8fcc5140677;p=platform%2Fkernel%2Flinux-exynos.git

net_sched: check NULL on error path in route4_change()

On error path in route4_change(), 'f' could be NULL,
so we should check NULL before calling tcf_exts_destroy().

Fixes: b9a24bb76bf6 ("net_sched: properly handle failure case of tcf_exts_init()")
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/sched/cls_route.c b/net/sched/cls_route.c
index a4ce39b..455fc8f 100644
--- a/net/sched/cls_route.c
+++ b/net/sched/cls_route.c
@@ -559,7 +559,8 @@ static int route4_change(struct net *net, struct sk_buff *in_skb,
 	return 0;
 
 errout:
-	tcf_exts_destroy(&f->exts);
+	if (f)
+		tcf_exts_destroy(&f->exts);
 	kfree(f);
 	return err;
 }