From: Heiner Kallweit Date: Thu, 19 Jul 2018 06:15:16 +0000 (+0200) Subject: net: phy: consider PHY_IGNORE_INTERRUPT in phy_start_aneg_priv X-Git-Tag: v5.15~8391^2~22 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=215d08a85b9acf5e1fe9dbf50f1774cde333efef;p=platform%2Fkernel%2Flinux-starfive.git net: phy: consider PHY_IGNORE_INTERRUPT in phy_start_aneg_priv The situation described in the comment can occur also with PHY_IGNORE_INTERRUPT, therefore change the condition to include it. Fixes: f555f34fdc58 ("net: phy: fix auto-negotiation stall due to unavailable interrupt") Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller --- diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 537297d..6c9b24f 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -514,7 +514,7 @@ static int phy_start_aneg_priv(struct phy_device *phydev, bool sync) * negotiation may already be done and aneg interrupt may not be * generated. */ - if (phy_interrupt_is_valid(phydev) && (phydev->state == PHY_AN)) { + if (phydev->irq != PHY_POLL && phydev->state == PHY_AN) { err = phy_aneg_done(phydev); if (err > 0) { trigger = true;