From: Dan Carpenter Date: Fri, 1 Mar 2013 20:31:46 +0000 (+0300) Subject: applicom: use correct array offset X-Git-Tag: upstream/snapshot3+hdmi~5292^2~104 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2154e0a4f43e0c811737e391e7981d331e450d42;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git applicom: use correct array offset We're iterating through abps[] printing information, but here we use the wrong array index. IndexCard comes from the user and in this case it was specifically not range checked because we didn't expect to use it. Signed-off-by: Dan Carpenter Acked-by: Arnd Bergmann Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/char/applicom.c b/drivers/char/applicom.c index 25373df..974321a 100644 --- a/drivers/char/applicom.c +++ b/drivers/char/applicom.c @@ -804,8 +804,8 @@ static long ac_ioctl(struct file *file, unsigned int cmd, unsigned long arg) printk(KERN_INFO "Prom version board %d ....... V%d.%d %s", i+1, - (int)(readb(apbs[IndexCard].RamIO + VERS) >> 4), - (int)(readb(apbs[IndexCard].RamIO + VERS) & 0xF), + (int)(readb(apbs[i].RamIO + VERS) >> 4), + (int)(readb(apbs[i].RamIO + VERS) & 0xF), boardname);