From: Matt Arsenault Date: Tue, 18 Jan 2022 19:10:26 +0000 (-0500) Subject: OpenMP: Remove -fno-experimental-isel flag from testing X-Git-Tag: upstream/17.0.6~27448 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2142dc31df05c46bc9294640715f6ebbed41f48c;p=platform%2Fupstream%2Fllvm.git OpenMP: Remove -fno-experimental-isel flag from testing This effectively reverts 6f9e25d3824fb7b03dc6a403e1962d80a9c88ebe. I didn't follow the complete history, but it seems this was added due to AArch64's output changing in some fallback. Blockaddress definitely works now, so just remove this. --- diff --git a/openmp/cmake/DetectTestCompiler/CMakeLists.txt b/openmp/cmake/DetectTestCompiler/CMakeLists.txt index dc709f5..bc2aa52 100644 --- a/openmp/cmake/DetectTestCompiler/CMakeLists.txt +++ b/openmp/cmake/DetectTestCompiler/CMakeLists.txt @@ -30,20 +30,6 @@ find_package(Threads REQUIRED) set(C_FLAGS "${OpenMP_C_FLAGS} ${CMAKE_THREAD_LIBS_INIT}") set(CXX_FLAGS "${OpenMP_CXX_FLAGS} ${CMAKE_THREAD_LIBS_INIT}") -# TODO: Implement blockaddress in GlobalISel and remove this flag! -if (CMAKE_C_COMPILER_ID STREQUAL "Clang") - check_c_compiler_flag("-fno-experimental-isel" C_HAS_EXPERIMENTAL_ISEL_FLAG) - check_cxx_compiler_flag("-fno-experimental-isel" CXX_HAS_EXPERIMENTAL_ISEL_FLAG) - macro(add_experimental_isel_flag lang) - if (${lang}_HAS_EXPERIMENTAL_ISEL_FLAG) - set(${lang}_FLAGS "-fno-experimental-isel ${${lang}_FLAGS}") - endif() - endmacro(add_experimental_isel_flag) - - add_experimental_isel_flag(C) - add_experimental_isel_flag(CXX) -endif() - check_c_compiler_flag("-fno-omit-frame-pointer" C_HAS_OMIT_FRAME_POINTER) check_cxx_compiler_flag("-fno-omit-frame-pointer" CXX_HAS_OMIT_FRAME_POINTER) diff --git a/openmp/cmake/OpenMPTesting.cmake b/openmp/cmake/OpenMPTesting.cmake index 1a9e0de..a93f719 100644 --- a/openmp/cmake/OpenMPTesting.cmake +++ b/openmp/cmake/OpenMPTesting.cmake @@ -154,8 +154,7 @@ else() set(OPENMP_TEST_COMPILER_HAS_TSAN_FLAGS 0) endif() set(OPENMP_TEST_COMPILER_HAS_OMP_H 1) - # TODO: Implement blockaddress in GlobalISel and remove this flag! - set(OPENMP_TEST_COMPILER_OPENMP_FLAGS "-fopenmp ${OPENMP_TEST_COMPILER_THREAD_FLAGS} -fno-experimental-isel") + set(OPENMP_TEST_COMPILER_OPENMP_FLAGS "-fopenmp ${OPENMP_TEST_COMPILER_THREAD_FLAGS}") set(OPENMP_TEST_COMPILER_HAS_OMIT_FRAME_POINTER_FLAGS 1) endif()