From: Trent Piepho Date: Tue, 1 Oct 2013 20:15:11 +0000 (-0700) Subject: spi: spi-mxs: Remove full duplex check, spi core already does it X-Git-Tag: v5.15~19014^2~13^2~6 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=210f65fedf1d26d0a1d604fa82425018f7ad6090;p=platform%2Fkernel%2Flinux-starfive.git spi: spi-mxs: Remove full duplex check, spi core already does it Because the driver sets the SPI_MASTER_HALF_DUPLEX flag, the spi core will check transfers to insure they are not full duplex. It's not necessary to check that in the spi-mxs driver as well. Signed-off-by: Trent Piepho Cc: Marek Vasut Cc: Fabio Estevam Cc: Shawn Guo Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c index a9a273e..de7387e 100644 --- a/drivers/spi/spi-mxs.c +++ b/drivers/spi/spi-mxs.c @@ -399,12 +399,6 @@ static int mxs_spi_transfer_one(struct spi_master *master, /* De-assert on last transfer, inverted by cs_change flag */ flag = (&t->transfer_list == m->transfers.prev) ^ t->cs_change ? TXRX_DEASSERT_CS : 0; - if ((t->rx_buf && t->tx_buf) || (t->rx_dma && t->tx_dma)) { - dev_err(ssp->dev, - "Cannot send and receive simultaneously\n"); - status = -EINVAL; - break; - } /* * Small blocks can be transfered via PIO.