From: Dan Streetman Date: Wed, 22 Jul 2015 18:26:35 +0000 (-0400) Subject: crypto: nx - use common code for both NX decompress success cases X-Git-Tag: v4.3-rc3~6^2~102 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=20fc311fc0e14d9f5ef72cfe785fd2b3f6339ab8;p=profile%2Fcommon%2Fplatform%2Fkernel%2Flinux-artik7.git crypto: nx - use common code for both NX decompress success cases Replace the duplicated finishing code (set destination buffer length and set return code to 0) in the case of decompressing a buffer with no header with a goto to the success case of decompressing a buffer with a header. This is a trivial change that allows both success cases to use common code, and includes the pr_debug() msg in both cases as well. Signed-off-by: Dan Streetman Signed-off-by: Herbert Xu --- diff --git a/drivers/crypto/nx/nx-842-crypto.c b/drivers/crypto/nx/nx-842-crypto.c index 3288a70..51ca168 100644 --- a/drivers/crypto/nx/nx-842-crypto.c +++ b/drivers/crypto/nx/nx-842-crypto.c @@ -520,10 +520,7 @@ static int nx842_crypto_decompress(struct crypto_tfm *tfm, if (ret) goto unlock; - *dlen = p.ototal; - - ret = 0; - goto unlock; + goto success; } if (!hdr->groups) { @@ -557,6 +554,7 @@ static int nx842_crypto_decompress(struct crypto_tfm *tfm, goto unlock; } +success: *dlen = p.ototal; pr_debug("decompress total slen %x dlen %x\n", slen, *dlen);