From: Sergey Andreenko Date: Mon, 19 Mar 2018 22:08:09 +0000 (-0700) Subject: delete unused debug arg from genChangeLife and compChangeLife. (#17041) X-Git-Tag: accepted/tizen/unified/20190422.045933~2586 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=20f7c219e79f55ab8062282c6cb1d89310f365ea;p=platform%2Fupstream%2Fcoreclr.git delete unused debug arg from genChangeLife and compChangeLife. (#17041) * delete unused debug arg from genChangeLife(VARSET_VALARG_TP * remove unused debug arg from compChangeLife --- diff --git a/src/jit/codegencommon.cpp b/src/jit/codegencommon.cpp index 22491c8..2c605c9 100644 --- a/src/jit/codegencommon.cpp +++ b/src/jit/codegencommon.cpp @@ -1082,17 +1082,13 @@ void Compiler::compUpdateLifeVar(GenTree* tree, VARSET_TP* pLastUseVars) template void Compiler::compUpdateLifeVar(GenTree* tree, VARSET_TP* pLastUseVars); template -void Compiler::compChangeLife(VARSET_VALARG_TP newLife DEBUGARG(GenTree* tree)) +void Compiler::compChangeLife(VARSET_VALARG_TP newLife) { LclVarDsc* varDsc; #ifdef DEBUG if (verbose) { - if (tree != nullptr) - { - Compiler::printTreeID(tree); - } printf("Change life %s ", VarSetOps::ToString(this, compCurLife)); dumpConvertedVarSet(this, compCurLife); printf(" -> %s ", VarSetOps::ToString(this, newLife)); @@ -1163,7 +1159,7 @@ void Compiler::compChangeLife(VARSET_VALARG_TP newLife DEBUGARG(GenTree* tree)) { codeGen->gcInfo.gcRegByrefSetCur &= ~regMask; } - codeGen->genUpdateRegLife(varDsc, false /*isBorn*/, true /*isDying*/ DEBUGARG(tree)); + codeGen->genUpdateRegLife(varDsc, false /*isBorn*/, true /*isDying*/ DEBUGARG(nullptr)); } #ifndef LEGACY_BACKEND // This isn't in a register, so update the gcVarPtrSetCur. @@ -1197,7 +1193,7 @@ void Compiler::compChangeLife(VARSET_VALARG_TP newLife DEBUGARG(GenTree* tree)) #endif // DEBUG VarSetOps::RemoveElemD(this, codeGen->gcInfo.gcVarPtrSetCur, bornVarIndex); #endif // !LEGACY_BACKEND - codeGen->genUpdateRegLife(varDsc, true /*isBorn*/, false /*isDying*/ DEBUGARG(tree)); + codeGen->genUpdateRegLife(varDsc, true /*isBorn*/, false /*isDying*/ DEBUGARG(nullptr)); regMaskTP regMask = varDsc->lvRegMask(); if (isGCRef) { @@ -1222,7 +1218,7 @@ void Compiler::compChangeLife(VARSET_VALARG_TP newLife DEBUGARG(GenTree* tree)) } // Need an explicit instantiation. -template void Compiler::compChangeLife(VARSET_VALARG_TP newLife DEBUGARG(GenTree* tree)); +template void Compiler::compChangeLife(VARSET_VALARG_TP newLife); #ifdef LEGACY_BACKEND diff --git a/src/jit/codegenlegacy.cpp b/src/jit/codegenlegacy.cpp index 7fb946d..648a481 100644 --- a/src/jit/codegenlegacy.cpp +++ b/src/jit/codegenlegacy.cpp @@ -12971,7 +12971,7 @@ void CodeGen::genCodeForBBlist() gcInfo.gcMarkRegSetNpt(gcrefRegs | byrefRegs); if (!VarSetOps::Equal(compiler, compiler->compCurLife, block->bbLiveOut)) - compiler->genChangeLife(block->bbLiveOut DEBUGARG(NULL)); + compiler->genChangeLife(block->bbLiveOut); /* Both stacks should always be empty on exit from a basic block */ diff --git a/src/jit/compiler.h b/src/jit/compiler.h index f1c9529..0bbe9e2 100644 --- a/src/jit/compiler.h +++ b/src/jit/compiler.h @@ -7249,11 +7249,11 @@ public: GenTree* compCurLifeTree; // node after which compCurLife has been computed template - void compChangeLife(VARSET_VALARG_TP newLife DEBUGARG(GenTree* tree)); + void compChangeLife(VARSET_VALARG_TP newLife); - void genChangeLife(VARSET_VALARG_TP newLife DEBUGARG(GenTree* tree)) + void genChangeLife(VARSET_VALARG_TP newLife) { - compChangeLife(newLife DEBUGARG(tree)); + compChangeLife(newLife); } template diff --git a/src/jit/compiler.hpp b/src/jit/compiler.hpp index 36012fb..2a6fd86 100644 --- a/src/jit/compiler.hpp +++ b/src/jit/compiler.hpp @@ -3589,7 +3589,7 @@ inline void Compiler::compUpdateLife(VARSET_VALARG_TP newLife) { if (!VarSetOps::Equal(this, compCurLife, newLife)) { - compChangeLife(newLife DEBUGARG(nullptr)); + compChangeLife(newLife); } #ifdef DEBUG else