From: Tejun Heo <htejun@gmail.com>
Date: Tue, 14 Apr 2009 03:59:03 +0000 (+0900)
Subject: pata_legacy: fix no device fail path
X-Git-Tag: v2.6.30-rc3~73^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=20cbf5f8c0fe3df2ddbde1f334993b4dda18a651;p=platform%2Fkernel%2Flinux-3.10.git

pata_legacy: fix no device fail path

When pata_legacy can't detect any device, it unregisters the
platform_device and fails detection.  However, it forgets to detach
ata host triggering weird failures as the host later gets freed by
devres while still attached.  Fix it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---

diff --git a/drivers/ata/pata_legacy.c b/drivers/ata/pata_legacy.c
index 3f830f0..0c6dde8 100644
--- a/drivers/ata/pata_legacy.c
+++ b/drivers/ata/pata_legacy.c
@@ -1032,6 +1032,7 @@ static __init int legacy_init_one(struct legacy_probe *probe)
 			return 0;
 		}
 	}
+	ata_host_detach(host);
 fail:
 	platform_device_unregister(pdev);
 	return ret;