From: Hans Wennborg Date: Wed, 29 Apr 2020 13:12:43 +0000 (+0200) Subject: Revert 6654719 "[CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply... X-Git-Tag: llvmorg-12-init~7474 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=209ab6d8835cd88320ceb814893759cfbda91d15;p=platform%2Fupstream%2Fllvm.git Revert 6654719 "[CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC" It broke building libclang.dll in Windows builds configured with LLVM_ENABLE_PIC=OFF. See discussion on the cfe-commits thread. --- diff --git a/clang/tools/libclang/CMakeLists.txt b/clang/tools/libclang/CMakeLists.txt index 9368501..bb2b14c 100644 --- a/clang/tools/libclang/CMakeLists.txt +++ b/clang/tools/libclang/CMakeLists.txt @@ -77,7 +77,7 @@ if(MSVC) set(LLVM_EXPORTED_SYMBOL_FILE) endif() -if(LLVM_ENABLE_PIC) +if(LLVM_ENABLE_PIC OR NOT LIBCLANG_BUILD_STATIC) set(ENABLE_SHARED SHARED) endif()