From: Pan Bian Date: Thu, 1 Dec 2016 06:25:44 +0000 (+0800) Subject: clk: clk-wm831x: fix a logic error X-Git-Tag: v4.10-rc3~8^2~17 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=20979202ee6e4c68dab7bcf408787225a656d18e;p=platform%2Fkernel%2Flinux-exynos.git clk: clk-wm831x: fix a logic error Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188561. Function wm831x_clkout_is_prepared() returns "true" when it fails to read CLOCK_CONTROL_1. "true" means the device is already prepared. So return "true" on the read failure seems improper. Signed-off-by: Pan Bian Acked-by: Charles Keepax Fixes: f05259a6ffa4 ("clk: wm831x: Add initial WM831x clock driver") Signed-off-by: Stephen Boyd --- diff --git a/drivers/clk/clk-wm831x.c b/drivers/clk/clk-wm831x.c index f4fdac5..0621fbf 100644 --- a/drivers/clk/clk-wm831x.c +++ b/drivers/clk/clk-wm831x.c @@ -243,7 +243,7 @@ static int wm831x_clkout_is_prepared(struct clk_hw *hw) if (ret < 0) { dev_err(wm831x->dev, "Unable to read CLOCK_CONTROL_1: %d\n", ret); - return true; + return false; } return (ret & WM831X_CLKOUT_ENA) != 0;