From: Baokun Li Date: Wed, 9 Jun 2021 07:14:30 +0000 (+0800) Subject: misc: bcm-vk: use list_move_tail instead of list_del/list_add_tail in bcm_vk_msg.c X-Git-Tag: v5.15~792^2~68 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=20827dddf27d433e45703a4f9bf0a66ab957dd0c;p=platform%2Fkernel%2Flinux-starfive.git misc: bcm-vk: use list_move_tail instead of list_del/list_add_tail in bcm_vk_msg.c Using list_move_tail() instead of list_del() + list_add_tail() in bcm_vk_msg.c. Reported-by: Hulk Robot Signed-off-by: Baokun Li Link: https://lore.kernel.org/r/20210609071430.1337400-1-libaokun1@huawei.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/misc/bcm-vk/bcm_vk_msg.c b/drivers/misc/bcm-vk/bcm_vk_msg.c index 6efc52b..066b9ef 100644 --- a/drivers/misc/bcm-vk/bcm_vk_msg.c +++ b/drivers/misc/bcm-vk/bcm_vk_msg.c @@ -354,8 +354,7 @@ static void bcm_vk_drain_all_pend(struct device *dev, for (num = 0; num < chan->q_nr; num++) { list_for_each_entry_safe(entry, tmp, &chan->pendq[num], node) { if ((!ctx) || (entry->ctx->idx == ctx->idx)) { - list_del(&entry->node); - list_add_tail(&entry->node, &del_q); + list_move_tail(&entry->node, &del_q); } } }