From: Markus Lehtonen Date: Thu, 12 Jan 2012 13:40:54 +0000 (+0200) Subject: gbp-pq: refactor args of write_patch() X-Git-Tag: debian/0.6.0_git20120226~7 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=20819006d71274bd809cf3e1aee62382e24200cb;p=tools%2Fgit-buildpackage.git gbp-pq: refactor args of write_patch() Allows defining the formerly hardcoded patch_dir. This makes write_patch() re-usable in the upcoming RPM-tools. Signed-off-by: Guido Günther --- diff --git a/gbp/scripts/pq.py b/gbp/scripts/pq.py index ec9ae6d..ad94525 100755 --- a/gbp/scripts/pq.py +++ b/gbp/scripts/pq.py @@ -72,10 +72,10 @@ def pq_branch_base(pq_branch): if is_pq_branch(pq_branch): return pq_branch[len(PQ_BRANCH_PREFIX):] -def write_patch(patch, options): +def write_patch(patch, patch_dir, options): """Write the patch exported by 'git-format-patch' to it's final location (as specified in the commit)""" - oldname = patch[len(PATCH_DIR):] + oldname = os.path.basename(patch) newname = oldname tmpname = patch + ".gbp" old = file(patch, 'r') @@ -101,9 +101,9 @@ def write_patch(patch, options): newname = m.group('name') if topic: - topicdir = os.path.join(PATCH_DIR, topic) + topicdir = os.path.join(patch_dir, topic) else: - topicdir = PATCH_DIR + topicdir = patch_dir if not os.path.isdir(topicdir): os.makedirs(topicdir, 0755) @@ -139,7 +139,7 @@ def export_patches(repo, branch, options): f = file(SERIES_FILE, 'w') gbp.log.info("Regenerating patch queue in '%s'." % PATCH_DIR) for patch in patches: - filename = write_patch(patch, options) + filename = write_patch(patch, PATCH_DIR, options) f.write(filename[len(PATCH_DIR):] + '\n') f.close()