From: Axel Lin Date: Thu, 13 Sep 2012 22:15:36 +0000 (+0800) Subject: HID: picolcd_core: Remove setting hdev->claimed before calling hid_hw_start() X-Git-Tag: upstream/snapshot3+hdmi~6622^2~2^4~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=206e3f1cda4d6113bdbb3656917d481b9ad447e4;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git HID: picolcd_core: Remove setting hdev->claimed before calling hid_hw_start() Current implementation of hid_hw_start() allows connect_mask to be 0. Setting hdev->claimed = HID_CLAIMED_INPUT before calling hid_hw_start() is not necessary. Remove it. Signed-off-by: Axel Lin Acked-By: Bruno Prémont Signed-off-by: Jiri Kosina --- diff --git a/drivers/hid/hid-picolcd_core.c b/drivers/hid/hid-picolcd_core.c index bd2a751..86df26e 100644 --- a/drivers/hid/hid-picolcd_core.c +++ b/drivers/hid/hid-picolcd_core.c @@ -565,11 +565,7 @@ static int picolcd_probe(struct hid_device *hdev, goto err_cleanup_data; } - /* We don't use hidinput but hid_hw_start() fails if nothing is - * claimed. So spoof claimed input. */ - hdev->claimed = HID_CLAIMED_INPUT; error = hid_hw_start(hdev, 0); - hdev->claimed = 0; if (error) { hid_err(hdev, "hardware start failed\n"); goto err_cleanup_data;