From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date: Tue, 18 Sep 2018 07:14:11 +0000 (+0200)
Subject: Cast RLIM_INFINITY to rlim_t to fix 64-bit Solaris 10 build
X-Git-Tag: users/ARM/embedded-binutils-master-2018q4~694
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=206c1947c1cb8e4ac6abb8e6803c762200167cde;p=external%2Fbinutils.git

Cast RLIM_INFINITY to rlim_t to fix 64-bit Solaris 10 build

gdb doesn't currently build on 64-bit Solaris 10:

/vol/src/gnu/gdb/hg/master/local/gdb/utils.c: In function ‘void dump_core()’:
/vol/src/gnu/gdb/hg/master/local/gdb/utils.c:223:55: error: narrowing conversion
 of ‘-3’ from ‘long int’ to ‘rlim_t’ {aka ‘long unsigned int’} inside {
} [-Wnarrowing]
   struct rlimit rlim = { RLIM_INFINITY, RLIM_INFINITY };
                                                       ^
/vol/src/gnu/gdb/hg/master/local/gdb/utils.c:223:55: error: narrowing conversion
 of ‘-3’ from ‘long int’ to ‘rlim_t’ {aka ‘long unsigned int’} inside {
} [-Wnarrowing]

This was introduced by

2018-08-27  Tom Tromey  <tom@tromey.com>

	PR build/23087:
	* configure: Rebuild.
	* warning.m4 (AM_GDB_WARNINGS): Remove -Wno-narrowing.

and can be fixed by the following patch.

Solaris 11 isn't affected because there <sys/resource.h> has

#define	RLIM_INFINITY	((rlim_t)-3l)

instead of

#define RLIM_INFINITY   (-3l)

on Solaris 10.

Tested on amd64-pc-solaris2.10 and amd64-pc-solaris2.11.

	* utils.c (dump_core) [HAVE_SETRLIMIT]: Cast RLIM_INFINITY to
	rlim_t.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index a468d8d..ddd2782 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2018-09-18  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
+
+	* utils.c (dump_core) [HAVE_SETRLIMIT]: Cast RLIM_INFINITY to
+	rlim_t.
+
 2018-09-17  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 
 	* python/lib/gdb/command/frame_filters.py (EnableFrameFilter):
diff --git a/gdb/utils.c b/gdb/utils.c
index d7980fe..8d4a744 100644
--- a/gdb/utils.c
+++ b/gdb/utils.c
@@ -220,7 +220,7 @@ void
 dump_core (void)
 {
 #ifdef HAVE_SETRLIMIT
-  struct rlimit rlim = { RLIM_INFINITY, RLIM_INFINITY };
+  struct rlimit rlim = { (rlim_t) RLIM_INFINITY, (rlim_t) RLIM_INFINITY };
 
   setrlimit (RLIMIT_CORE, &rlim);
 #endif /* HAVE_SETRLIMIT */