From: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date: Sun, 12 Dec 2010 21:13:13 +0000 (+0100)
Subject: jpegparse: avoid leaking converted comment string
X-Git-Tag: 1.19.3~507^2~16062^2~356
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2056f4a63344836d717eecdac4bb2bbf47e6a3a5;p=platform%2Fupstream%2Fgstreamer.git

jpegparse: avoid leaking converted comment string
---

diff --git a/gst/jpegformat/gstjpegparse.c b/gst/jpegformat/gstjpegparse.c
index 8dbc511..c1c6539 100644
--- a/gst/jpegformat/gstjpegparse.c
+++ b/gst/jpegformat/gstjpegparse.c
@@ -562,7 +562,7 @@ gst_jpeg_parse_read_header (GstJpegParse * parse, GstBuffer * buffer)
 
       case COM:{               /* read comment and post as tag */
         const guint8 *comment = NULL;
-        const gchar *comm;
+        gchar *comm;
         const gchar *env_vars[] = { "GST_JPEG_TAG_ENCODING",
           "GST_TAG_ENCODING", NULL
         };
@@ -572,7 +572,7 @@ gst_jpeg_parse_read_header (GstJpegParse * parse, GstBuffer * buffer)
         if (!gst_byte_reader_get_data (&reader, size - 2, &comment))
           goto error;
 
-        comm = (const gchar *) comment;
+        comm = (gchar *) comment;
         comm = gst_tag_freeform_string_to_utf8 (comm, size - 2, env_vars);
 
         if (comm) {
@@ -580,6 +580,7 @@ gst_jpeg_parse_read_header (GstJpegParse * parse, GstBuffer * buffer)
             parse->priv->tags = gst_tag_list_new ();
           gst_tag_list_add (parse->priv->tags, GST_TAG_MERGE_REPLACE,
               GST_TAG_COMMENT, comm, NULL);
+          g_free (comm);
         }
         break;
       }