From: Jiri Slaby Date: Tue, 27 Apr 2010 21:11:20 +0000 (-0300) Subject: V4L/DVB: dvb-usb: gp8psk, fix potential null derefernce X-Git-Tag: v2.6.35-rc1~480^2~75 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=205161ed03b53c467dd669a340ea704ce0fb6f9e;p=profile%2Fcommon%2Fkernel-common.git V4L/DVB: dvb-usb: gp8psk, fix potential null derefernce Stanse found that in gp8psk_load_bcm4500fw there is missing a check for return value of kmalloc. Add one and bail out appropriatelly. Signed-off-by: Jiri Slaby Signed-off-by: Andrew Morton Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/dvb/dvb-usb/gp8psk.c b/drivers/media/dvb/dvb-usb/gp8psk.c index afb444d..45106ac 100644 --- a/drivers/media/dvb/dvb-usb/gp8psk.c +++ b/drivers/media/dvb/dvb-usb/gp8psk.c @@ -105,6 +105,10 @@ static int gp8psk_load_bcm4500fw(struct dvb_usb_device *d) ptr = fw->data; buf = kmalloc(64, GFP_KERNEL | GFP_DMA); + if (!buf) { + ret = -ENOMEM; + goto out_rel_fw; + } while (ptr[0] != 0xff) { u16 buflen = ptr[0] + 4;