From: Iago Toral Quiroga <itoral@igalia.com>
Date: Thu, 20 Feb 2020 15:12:59 +0000 (+0100)
Subject: v3dv: add assertions for unimplemented fallback paths
X-Git-Tag: upstream/21.0.0~4124
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=204d06cc267112fa1bfff23e7de8b370db20d5b9;p=platform%2Fupstream%2Fmesa.git

v3dv: add assertions for unimplemented fallback paths

This helps with identifying tests that fail on supported paths from tests
that hit unimplemented paths in the driver.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6766>
---

diff --git a/src/broadcom/vulkan/v3dv_meta_copy.c b/src/broadcom/vulkan/v3dv_meta_copy.c
index f5e7342..f69aefa 100644
--- a/src/broadcom/vulkan/v3dv_meta_copy.c
+++ b/src/broadcom/vulkan/v3dv_meta_copy.c
@@ -680,6 +680,8 @@ v3dv_CmdCopyImageToBuffer(VkCommandBuffer commandBuffer,
    for (uint32_t i = 0; i < regionCount; i++) {
       if (can_use_tlb_copy_for_image_offset(&pRegions[i].imageOffset))
          copy_image_to_buffer_tlb(cmd_buffer, buffer, image, &pRegions[i]);
+      else
+         assert(!"Fallback path for vkCopyImageToBuffer not implemented");
    }
 }
 
@@ -829,6 +831,8 @@ v3dv_CmdCopyImage(VkCommandBuffer commandBuffer,
       if (can_use_tlb_copy_for_image_offset(&pRegions[i].dstOffset) &&
           can_use_tlb_copy_for_image_offset(&pRegions[i].srcOffset)) {
          copy_image_tlb(cmd_buffer, dst, src, &pRegions[i]);
+      } else {
+         assert(!"Fallback path for vkCopyImageToImage not implemented");
       }
    }
 }
@@ -1517,5 +1521,7 @@ v3dv_CmdCopyBufferToImage(VkCommandBuffer commandBuffer,
    for (uint32_t i = 0; i < regionCount; i++) {
       if (can_use_tlb_copy_for_image_offset(&pRegions[i].imageOffset))
          copy_buffer_to_image_tlb(cmd_buffer, image, buffer, &pRegions[i]);
+      else
+         assert(!"Fallback path for vkCmdCopyBufferToImage not implemented");
    }
 }