From: Dave Stevenson Date: Thu, 27 Aug 2020 15:30:26 +0000 (+0100) Subject: media: bcm2835-unicam: Drop WARN on uing direct cache alias X-Git-Tag: accepted/tizen/unified/20240422.153132~744 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2033bafd339a2297a6c6fbe6372299e33eaff91a;p=platform%2Fkernel%2Flinux-rpi.git media: bcm2835-unicam: Drop WARN on uing direct cache alias Pi 0&1 pass all ARM accesses through the VPU L2 cache, therefore the dma-ranges property sets the cache alias bits to other than the direct alias, hence this WARN was firing. It was overprotective coding, so assume that everything is OK with the dma-ranges, and remove the WARN. Signed-off-by: Dave Stevenson --- diff --git a/drivers/media/platform/bcm2835/bcm2835-unicam.c b/drivers/media/platform/bcm2835/bcm2835-unicam.c index 1e9c9f5..85e98ea 100644 --- a/drivers/media/platform/bcm2835/bcm2835-unicam.c +++ b/drivers/media/platform/bcm2835/bcm2835-unicam.c @@ -711,13 +711,6 @@ static void unicam_wr_dma_addr(struct unicam_device *dev, dma_addr_t dmaaddr, { dma_addr_t endaddr = dmaaddr + buffer_size; - /* - * dmaaddr and endaddr should be a 32-bit address with the top two bits - * set to 0x3 to signify uncached access through the Videocore memory - * controller. - */ - WARN_ON((dmaaddr >> 30) != 0x3 || (endaddr >> 30) != 0x3); - if (pad_id == IMAGE_PAD) { reg_write(dev, UNICAM_IBSA0, dmaaddr); reg_write(dev, UNICAM_IBEA0, endaddr);