From: Jonathan Cameron Date: Sun, 8 May 2022 17:56:39 +0000 (+0100) Subject: iio: dac: ltc2688: Fix alignment for DMA safety X-Git-Tag: v6.6.17~6911^2~26^2~94 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=2030708377a219b548a9a36da57d3852382baf1d;p=platform%2Fkernel%2Flinux-rpi.git iio: dac: ltc2688: Fix alignment for DMA safety ____cacheline_aligned is an insufficient guarantee for non-coherent DMA on platforms with 128 byte cachelines above L1. Switch to the updated IIO_DMA_MINALIGN definition. Update the comment to include 'may'. Fixes: 832cb9eeb931 ("iio: dac: add support for ltc2688") Signed-off-by: Jonathan Cameron Acked-by: Nuno Sá Link: https://lore.kernel.org/r/20220508175712.647246-60-jic23@kernel.org --- diff --git a/drivers/iio/dac/ltc2688.c b/drivers/iio/dac/ltc2688.c index 937b0d2..28bdde2 100644 --- a/drivers/iio/dac/ltc2688.c +++ b/drivers/iio/dac/ltc2688.c @@ -91,10 +91,10 @@ struct ltc2688_state { struct mutex lock; int vref; /* - * DMA (thus cache coherency maintenance) requires the + * DMA (thus cache coherency maintenance) may require the * transfer buffers to live in their own cache lines. */ - u8 tx_data[6] ____cacheline_aligned; + u8 tx_data[6] __aligned(IIO_DMA_MINALIGN); u8 rx_data[3]; };