From: Sangchul Lee <sc11.lee@samsung.com>
Date: Wed, 20 Apr 2022 08:48:01 +0000 (+0900)
Subject: webrtcbin: Avoid access of freed memory
X-Git-Tag: submit/tizen/20220425.020050~5
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=20078cea290490abc379d37ebd7d2c6d88bddfa5;p=platform%2Fupstream%2Fgstreamer.git

webrtcbin: Avoid access of freed memory

[Version] 1.20.0-17
[Issue Type] Coverity defects fix

Change-Id: Ib6a92a06db1af09f33d879a196739d6b65f09885
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
---

diff --git a/packaging/gstreamer.spec b/packaging/gstreamer.spec
index 6c0120d0c5..ede827cd87 100644
--- a/packaging/gstreamer.spec
+++ b/packaging/gstreamer.spec
@@ -60,7 +60,7 @@
 
 Name:           %{_name}
 Version:        1.20.0
-Release:        16
+Release:        17
 Summary:        Streaming-Media Framework Runtime
 License:        LGPL-2.0+
 Group:          Multimedia/Framework
diff --git a/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c b/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c
index 069ea3c108..d30b359baa 100644
--- a/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c
+++ b/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c
@@ -1879,7 +1879,9 @@ _find_codec_preferences (GstWebRTCBin * webrtc,
 
       caps = _query_pad_caps (webrtc, rtp_trans, pad, filter, error);
     }
+#ifndef TIZEN_FEATURE_WEBRTC_MODIFICATION
     gst_object_unref (pad);
+#endif
 
     if (*error)
       goto out;
@@ -1933,6 +1935,10 @@ _find_codec_preferences (GstWebRTCBin * webrtc,
 
 out:
 
+#ifdef TIZEN_FEATURE_WEBRTC_MODIFICATION
+  if (pad)
+    gst_object_unref (pad);
+#endif
   if (codec_preferences)
     gst_caps_unref (codec_preferences);
 
@@ -6799,8 +6805,15 @@ out:
   return ret;
 
 error:
+#ifndef TIZEN_FEATURE_WEBRTC_MODIFICATON
   if (ret)
     gst_object_unref (ret);
+#else
+  if (ret) {
+    gst_object_unref (ret);
+    ret = NULL;
+  }
+#endif
   goto out;
 }