From: Hoegeun Kwon Date: Wed, 3 May 2023 05:04:20 +0000 (+0900) Subject: pwm: starfive: Fix incompatible pointer types X-Git-Tag: accepted/tizen/unified/riscv/20230725.071352~108 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1f80e486f862f33e43efd4bc5390c1b2a6e7c74b;p=platform%2Fkernel%2Flinux-starfive.git pwm: starfive: Fix incompatible pointer types Fix starfive_pwm_ptc_get_state func and get_state pointer func and return types not matching. In the current kernel version, get_status does not use return value, so no problem. Fix return type to void. drivers/pwm/pwm-starfive-ptc.c:152:15: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] .get_state = starfive_pwm_ptc_get_state, ^~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: Ifd9fb81ead2b174d138dcad60f464e484074aac4 Signed-off-by: Hoegeun Kwon --- diff --git a/drivers/pwm/pwm-starfive-ptc.c b/drivers/pwm/pwm-starfive-ptc.c index 239df796d240..a393f3ccbbe8 100644 --- a/drivers/pwm/pwm-starfive-ptc.c +++ b/drivers/pwm/pwm-starfive-ptc.c @@ -68,7 +68,7 @@ struct starfive_pwm_ptc_device *chip_to_starfive_ptc(struct pwm_chip *c) return container_of(c, struct starfive_pwm_ptc_device, chip); } -static int starfive_pwm_ptc_get_state(struct pwm_chip *chip, +static void starfive_pwm_ptc_get_state(struct pwm_chip *chip, struct pwm_device *dev, struct pwm_state *state) { @@ -85,8 +85,6 @@ static int starfive_pwm_ptc_get_state(struct pwm_chip *chip, state->duty_cycle = data_hrc * pwm_clk_ns; state->polarity = PWM_POLARITY_NORMAL; state->enabled = 1; - - return 0; } static int starfive_pwm_ptc_apply(struct pwm_chip *chip,