From: Wei Yongjun Date: Wed, 22 Aug 2012 21:28:40 +0000 (+0000) Subject: w5300: using eth_hw_addr_random() for random MAC and set device flag X-Git-Tag: v3.7-rc1~145^2~282 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1f7c9ae7a014d994c01a7dd59333f2fcef2aba58;p=platform%2Fkernel%2Flinux-3.10.git w5300: using eth_hw_addr_random() for random MAC and set device flag Using eth_hw_addr_random() to generate a random Ethernet address (MAC) to be used by a net device and set addr_assign_type. Not need to duplicating its implementation. spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/wiznet/w5300.c b/drivers/net/ethernet/wiznet/w5300.c index bdd8891..88943d9 100644 --- a/drivers/net/ethernet/wiznet/w5300.c +++ b/drivers/net/ethernet/wiznet/w5300.c @@ -557,8 +557,7 @@ static int __devinit w5300_hw_probe(struct platform_device *pdev) if (data && is_valid_ether_addr(data->mac_addr)) { memcpy(ndev->dev_addr, data->mac_addr, ETH_ALEN); } else { - eth_random_addr(ndev->dev_addr); - ndev->addr_assign_type |= NET_ADDR_RANDOM; + eth_hw_addr_random(ndev); } mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);