From: Bjorn Helgaas <bhelgaas@google.com>
Date: Thu, 12 Mar 2015 17:30:11 +0000 (-0500)
Subject: PCI: Show driver, BAR#, and resource on pci_ioremap_bar() failure
X-Git-Tag: v4.1~367^2~3^3~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1f7bf3bfb5d60c87dcaa708fd9eabbec93f15830;p=platform%2Fkernel%2Flinux-amlogic.git

PCI: Show driver, BAR#, and resource on pci_ioremap_bar() failure

Use dev_warn() to complain about a pci_ioremap_bar() failure so we can
include the driver name, BAR number, and the resource itself.  We could use
dev_WARN() to also get the backtrace as we did previously, but I think
that's more information than we need.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 81f06e8..a6d191a 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -126,15 +126,16 @@ EXPORT_SYMBOL_GPL(pci_bus_max_busnr);
 #ifdef CONFIG_HAS_IOMEM
 void __iomem *pci_ioremap_bar(struct pci_dev *pdev, int bar)
 {
+	struct resource *res = &pdev->resource[bar];
+
 	/*
 	 * Make sure the BAR is actually a memory resource, not an IO resource
 	 */
-	if (!(pci_resource_flags(pdev, bar) & IORESOURCE_MEM)) {
-		WARN_ON(1);
+	if (!(res->flags & IORESOURCE_MEM)) {
+		dev_warn(&pdev->dev, "can't ioremap BAR %d: %pR\n", bar, res);
 		return NULL;
 	}
-	return ioremap_nocache(pci_resource_start(pdev, bar),
-				     pci_resource_len(pdev, bar));
+	return ioremap_nocache(res->start, resource_size(res));
 }
 EXPORT_SYMBOL_GPL(pci_ioremap_bar);
 #endif