From: Jeff Skirvin Date: Fri, 16 Dec 2011 08:21:21 +0000 (+0000) Subject: [SCSI] libsas: Remove redundant phy state notification calls. X-Git-Tag: v3.4-rc1~6^2~112 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1f4fe89c9c78d3163cf1e389bdc6438a44b64244;p=profile%2Fivi%2Fkernel-x86-ivi.git [SCSI] libsas: Remove redundant phy state notification calls. In the case of an explicit sas_phy_enable call to disable a phy, the LLDD provides the calls to sas_phy_disconnected and the PHYE_LOSS_OF_SIGNAL event. NOTE: This assumes that the lldd(s) generate the notification, which appears to be the case, but only verfied on isci. Signed-off-by: Jeff Skirvin Signed-off-by: Dan Williams Signed-off-by: James Bottomley --- diff --git a/drivers/scsi/libsas/sas_init.c b/drivers/scsi/libsas/sas_init.c index 53ae893..cf1b532 100644 --- a/drivers/scsi/libsas/sas_init.c +++ b/drivers/scsi/libsas/sas_init.c @@ -268,11 +268,8 @@ static int sas_phy_enable(struct sas_phy *phy, int enable) if (enable) ret = transport_sas_phy_reset(phy, 0); - else { - sas_phy_disconnected(asd_phy); - sas_ha->notify_phy_event(asd_phy, PHYE_LOSS_OF_SIGNAL); + else ret = i->dft->lldd_control_phy(asd_phy, cmd, NULL); - } } else { struct sas_rphy *rphy = dev_to_rphy(phy->dev.parent); struct domain_device *ddev = sas_find_dev_by_rphy(rphy);