From: Matthew Waters <matthew@centricular.com>
Date: Wed, 11 Nov 2015 00:29:35 +0000 (+1100)
Subject: glslstage: properly return an error when we could not create the shader stage
X-Git-Tag: 1.16.2~955^2~595
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1f35fcf06dd414c9ee77d0dc82b1ae8ec67c1b20;p=platform%2Fupstream%2Fgst-plugins-base.git

glslstage: properly return an error when we could not create the shader stage

While it was erroring out correctly later, there were GLib warnings about
setting a GError over the top of another GError.
---

diff --git a/gst-libs/gst/gl/gstglslstage.c b/gst-libs/gst/gl/gstglslstage.c
index bd0405f..1eb99ce 100644
--- a/gst-libs/gst/gl/gstglslstage.c
+++ b/gst-libs/gst/gl/gstglslstage.c
@@ -436,6 +436,7 @@ _compile_shader (GstGLContext * context, struct compile *data)
   if (!_ensure_shader (data->stage)) {
     g_set_error (data->error, GST_GLSL_ERROR, GST_GLSL_ERROR_COMPILE,
         "Failed to create shader object");
+    data->result = FALSE;
     return;
   }