From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 19 Nov 2019 06:21:24 +0000 (+0300)
Subject: iio: adc: intel_mrfld_adc: Allocating too much data in probe()
X-Git-Tag: v5.15~4892^2~13^2~8
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1f310f77efa25660fcbf58629a96f8ee6aac85ba;p=platform%2Fkernel%2Flinux-starfive.git

iio: adc: intel_mrfld_adc: Allocating too much data in probe()

This probe function is passing the wrong size to devm_iio_device_alloc().
It is supposed to be the size of the private data.  Fortunately,
sizeof(*indio_dev) is larger than sizeof(struct mrfld_adc) so it doesn't
cause a runtime problem.

Fixes: a7118662734a ("iio: adc: intel_mrfld_adc: Add Basin Cove ADC driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---

diff --git a/drivers/iio/adc/intel_mrfld_adc.c b/drivers/iio/adc/intel_mrfld_adc.c
index 67d096f..c35a1be 100644
--- a/drivers/iio/adc/intel_mrfld_adc.c
+++ b/drivers/iio/adc/intel_mrfld_adc.c
@@ -185,7 +185,7 @@ static int mrfld_adc_probe(struct platform_device *pdev)
 	int irq;
 	int ret;
 
-	indio_dev = devm_iio_device_alloc(dev, sizeof(*indio_dev));
+	indio_dev = devm_iio_device_alloc(dev, sizeof(struct mrfld_adc));
 	if (!indio_dev)
 		return -ENOMEM;