From: Ramin Zaghi Date: Thu, 10 May 2012 14:20:19 +0000 (+0000) Subject: applied review #126 X-Git-Tag: v1.0.0~42^2~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1f0cb95867b13e3c87070ee362276a90510c006f;p=platform%2Fupstream%2Fne10.git applied review #126 --- diff --git a/headers/unit_test_abs_operation_x.h b/headers/unit_test_abs_operation_x.h index b25f6b0..965251c 100644 --- a/headers/unit_test_abs_operation_x.h +++ b/headers/unit_test_abs_operation_x.h @@ -87,7 +87,7 @@ arm_result_t test_operation() esp_buf[2] = (arm_float_t*) malloc( inbytes ); // copy of 1st input esp_buf[4] = (arm_float_t*) malloc( inbytes ); // use this as the output buffer - FILL_FLOAT_ARRAY_LIMIT( esp_buf[0], tmp_len * MAX_VEC_COMPONENTS ); // initialization the array with random numbers + FILL_FLOAT_ARRAY_LIMIT( esp_buf[0], tmp_len * MAX_VEC_COMPONENTS ); // initialize the array with random numbers memcpy( esp_buf[2], esp_buf[0], inbytes ); ftbl [ FTBL_IDX(opcode, impl) ] ( esp_buf[0] , esp_buf[0], tmp_len ); diff --git a/headers/unit_test_invmat_operation_x.h b/headers/unit_test_invmat_operation_x.h index ec393cd..b6a5383 100644 --- a/headers/unit_test_invmat_operation_x.h +++ b/headers/unit_test_invmat_operation_x.h @@ -52,7 +52,7 @@ arm_float_t * thesrc = NULL; arm_float_t * thedst[IMPL_COUNT]; // output from different implementations are stored in separate arrays for varification int done_init = 0; -// Eight buffers that are used for especial test cases such as when the destination and source point to the same address. +// Eight buffers that are used for special test cases such as when the destination and source point to the same address. // They may vary in size from one case to another and from one function to another. arm_float_t* esp_buf[8]; @@ -78,15 +78,15 @@ arm_result_t test_operation() done_init = 1; } - // test the especial case where dst == src + // test the special case where dst == src unsigned int tmp_len = 13; // Just an odd number bigger than 8 unsigned int inbytes = tmp_len * MAX_VEC_COMPONENTS * sizeof(arm_float_t); esp_buf[0] = (arm_float_t*) malloc( inbytes ); // input 1 esp_buf[2] = (arm_float_t*) malloc( inbytes ); // copy of 1st input esp_buf[4] = (arm_float_t*) malloc( inbytes ); // use this as the output buffer - FILL_FLOAT_ARRAY_LIMIT( esp_buf[0], tmp_len * MAX_VEC_COMPONENTS ); // initialization the array with random numbers - FILL_FLOAT_ARRAY_LIMIT( esp_buf[2], tmp_len * MAX_VEC_COMPONENTS ); // initialization the array with random numbers + FILL_FLOAT_ARRAY_LIMIT( esp_buf[0], tmp_len * MAX_VEC_COMPONENTS ); // initialize the array with random numbers + FILL_FLOAT_ARRAY_LIMIT( esp_buf[2], tmp_len * MAX_VEC_COMPONENTS ); // initialize the array with random numbers memcpy( esp_buf[2], esp_buf[0], inbytes ); ftbl [ FTBL_IDX(opcode, impl) ] ( esp_buf[0] , esp_buf[0], tmp_len ); diff --git a/headers/unit_test_mla_operation_x.h b/headers/unit_test_mla_operation_x.h index 8d56e28..892c3d4 100644 --- a/headers/unit_test_mla_operation_x.h +++ b/headers/unit_test_mla_operation_x.h @@ -56,7 +56,7 @@ arm_float_t * thesrc2 = NULL; arm_float_t * thedst[IMPL_COUNT]; // output from different implementations are stored in separate arrays for varification int done_init = 0; -// Eight buffers that are used for especial test cases such as when the destination and source point to the same address. +// Nine buffers that are used for special test cases such as when the destination and source point to the same address. // They may vary in size from one case to another and from one function to another. arm_float_t* esp_buf[9]; @@ -92,7 +92,7 @@ arm_result_t test_operation() done_init = 1; } - // test the especial case where dst == src + // test the special case where dst == src unsigned int tmp_len = 13; // Just an odd number bigger than 8 unsigned int inbytes = tmp_len * MAX_VEC_COMPONENTS * sizeof(float); esp_buf[0] = (arm_float_t*) malloc( inbytes ); // input 1 @@ -103,9 +103,9 @@ arm_result_t test_operation() esp_buf[5] = (arm_float_t*) malloc( inbytes ); // copy of 3nd input esp_buf[6] = (arm_float_t*) malloc( inbytes ); // use this as the output buffer - FILL_FLOAT_ARRAY_LIMIT( esp_buf[0], tmp_len * MAX_VEC_COMPONENTS ); // initialization the array with random numbers - FILL_FLOAT_ARRAY_LIMIT( esp_buf[1], tmp_len * MAX_VEC_COMPONENTS ); // initialization the array with random numbers - FILL_FLOAT_ARRAY_LIMIT( esp_buf[2], tmp_len * MAX_VEC_COMPONENTS ); // initialization the array with random numbers + FILL_FLOAT_ARRAY_LIMIT( esp_buf[0], tmp_len * MAX_VEC_COMPONENTS ); // initialize the array with random numbers + FILL_FLOAT_ARRAY_LIMIT( esp_buf[1], tmp_len * MAX_VEC_COMPONENTS ); // initialize the array with random numbers + FILL_FLOAT_ARRAY_LIMIT( esp_buf[2], tmp_len * MAX_VEC_COMPONENTS ); // initialize the array with random numbers memcpy( esp_buf[3], esp_buf[0], inbytes ); memcpy( esp_buf[4], esp_buf[1], inbytes ); memcpy( esp_buf[5], esp_buf[2], inbytes ); diff --git a/headers/unit_test_mlac_operation_x.h b/headers/unit_test_mlac_operation_x.h index 1736b8e..3b76abc 100644 --- a/headers/unit_test_mlac_operation_x.h +++ b/headers/unit_test_mlac_operation_x.h @@ -56,7 +56,7 @@ arm_float_t * thesrc = NULL; arm_float_t * thedst[IMPL_COUNT]; // output from different implementations are stored in separate arrays for varification int done_init = 0; -// Nine buffers that are used for especial test cases such as when the destination and source point to the same address. +// Nine buffers that are used for special test cases such as when the destination and source point to the same address. // They may vary in size from one case to another and from one function to another. arm_float_t* esp_buf[9]; @@ -96,7 +96,7 @@ arm_result_t test_operation() } - // test the especial case where dst == src + // test the special case where dst == src unsigned int tmp_len = 13; // Just an odd number bigger than 8 unsigned int inbytes = tmp_len * MAX_VEC_COMPONENTS * sizeof(float); esp_buf[0] = (arm_float_t*) malloc( inbytes ); // input 1 @@ -107,9 +107,9 @@ arm_result_t test_operation() esp_buf[5] = (arm_float_t*) malloc( inbytes ); // copy of 3nd input esp_buf[6] = (arm_float_t*) malloc( inbytes ); // use this as the output buffer - FILL_FLOAT_ARRAY_LIMIT( esp_buf[0], tmp_len * MAX_VEC_COMPONENTS ); // initialization the array with random numbers - FILL_FLOAT_ARRAY_LIMIT( esp_buf[1], tmp_len * MAX_VEC_COMPONENTS ); // initialization the array with random numbers - FILL_FLOAT_ARRAY_LIMIT( esp_buf[2], tmp_len * MAX_VEC_COMPONENTS ); // initialization the array with random numbers + FILL_FLOAT_ARRAY_LIMIT( esp_buf[0], tmp_len * MAX_VEC_COMPONENTS ); // initialize the array with random numbers + FILL_FLOAT_ARRAY_LIMIT( esp_buf[1], tmp_len * MAX_VEC_COMPONENTS ); // initialize the array with random numbers + FILL_FLOAT_ARRAY_LIMIT( esp_buf[2], tmp_len * MAX_VEC_COMPONENTS ); // initialize the array with random numbers memcpy( esp_buf[3], esp_buf[0], inbytes ); memcpy( esp_buf[4], esp_buf[1], inbytes ); memcpy( esp_buf[5], esp_buf[2], inbytes ); diff --git a/headers/unit_test_mulcmatvec_operation_x.h b/headers/unit_test_mulcmatvec_operation_x.h index 854422d..cae7c6b 100644 --- a/headers/unit_test_mulcmatvec_operation_x.h +++ b/headers/unit_test_mulcmatvec_operation_x.h @@ -55,7 +55,7 @@ arm_float_t * thesrc = NULL; arm_float_t * thedst[IMPL_COUNT]; // output from different implementations are stored in separate arrays for varification int done_init = 0; -// Eight buffers that are used for especial test cases such as when the destination and source point to the same address. +// Eight buffers that are used for special test cases such as when the destination and source point to the same address. // They may vary in size from one case to another and from one function to another. arm_float_t* esp_buf[8]; @@ -86,14 +86,14 @@ arm_result_t test_operation() done_init = 1; } - // test the especial case where dst == src + // test the special case where dst == src unsigned int tmp_len = 13; // Just an odd number bigger than 8 unsigned int inbytes = tmp_len * MAX_VEC_COMPONENTS * sizeof(arm_float_t); esp_buf[1] = (arm_float_t*) malloc( inbytes ); // input 2 esp_buf[3] = (arm_float_t*) malloc( inbytes ); // copy of 2nd input esp_buf[4] = (arm_float_t*) malloc( inbytes ); // use this as the output buffer - FILL_FLOAT_ARRAY_LIMIT( esp_buf[1], tmp_len * MAX_VEC_COMPONENTS ); // initialization the array with random numbers + FILL_FLOAT_ARRAY_LIMIT( esp_buf[1], tmp_len * MAX_VEC_COMPONENTS ); // initialize the array with random numbers memcpy( esp_buf[3], esp_buf[1], inbytes ); ftbl [ FTBL_IDX(opcode, impl) ] ( esp_buf[1] , thecst, esp_buf[1], tmp_len ); diff --git a/headers/unit_test_normalize_operation_x.h b/headers/unit_test_normalize_operation_x.h index d413a44..5a51b2b 100644 --- a/headers/unit_test_normalize_operation_x.h +++ b/headers/unit_test_normalize_operation_x.h @@ -52,7 +52,7 @@ arm_float_t * thesrc = NULL; arm_float_t * thedst[IMPL_COUNT]; // output from different implementations are stored in separate arrays for varification int done_init = 0; -// Eight buffers that are used for especial test cases such as when the destination and source point to the same address. +// Eight buffers that are used for special test cases such as when the destination and source point to the same address. // They may vary in size from one case to another and from one function to another. arm_float_t* esp_buf[8]; @@ -79,14 +79,14 @@ arm_result_t test_operation() } - // test the especial case where dst == src + // test the special case where dst == src unsigned int tmp_len = 13; // Just an odd number bigger than 8 unsigned int inbytes = tmp_len * MAX_VEC_COMPONENTS * sizeof(float); esp_buf[0] = (arm_float_t*) malloc( inbytes ); // input 1 esp_buf[2] = (arm_float_t*) malloc( inbytes ); // copy of 1st input esp_buf[4] = (arm_float_t*) malloc( inbytes ); // use this as the output buffer - FILL_FLOAT_ARRAY_LIMIT( esp_buf[0], tmp_len * MAX_VEC_COMPONENTS ); // initialization the array with random numbers + FILL_FLOAT_ARRAY_LIMIT( esp_buf[0], tmp_len * MAX_VEC_COMPONENTS ); // initialize the array with random numbers memcpy( esp_buf[2], esp_buf[0], inbytes ); ftbl [ FTBL_IDX(opcode, impl) ] ( esp_buf[0] , esp_buf[0], tmp_len ); diff --git a/headers/unit_test_x_operation_x.h b/headers/unit_test_x_operation_x.h index 6acffee..69b3959 100644 --- a/headers/unit_test_x_operation_x.h +++ b/headers/unit_test_x_operation_x.h @@ -54,7 +54,7 @@ arm_float_t * thesrc2 = NULL; arm_float_t * thedst[IMPL_COUNT]; // output from different implementations are stored in separate arrays for varification int done_init = 0; -// Eight buffers that are used for especial test cases such as when the destination and source point to the same address. +// Eight buffers that are used for special test cases such as when the destination and source point to the same address. // They may vary in size from one case to another and from one function to another. arm_float_t* esp_buf[8]; @@ -86,7 +86,7 @@ arm_result_t test_operation() } - // test the especial case where dst == src + // test the special case where dst == src unsigned int tmp_len = 13; // Just an odd number bigger than 8 unsigned int inbytes = tmp_len * MAX_VEC_COMPONENTS * sizeof(arm_float_t); esp_buf[0] = (arm_float_t*) malloc( inbytes ); // input 1 @@ -95,8 +95,8 @@ arm_result_t test_operation() esp_buf[3] = (arm_float_t*) malloc( inbytes ); // copy of 2nd input esp_buf[4] = (arm_float_t*) malloc( inbytes ); // use this as the output buffer - FILL_FLOAT_ARRAY_LIMIT( esp_buf[0], tmp_len * MAX_VEC_COMPONENTS ); // initialization the array with random numbers - FILL_FLOAT_ARRAY_LIMIT( esp_buf[1], tmp_len * MAX_VEC_COMPONENTS ); // initialization the array with random numbers + FILL_FLOAT_ARRAY_LIMIT( esp_buf[0], tmp_len * MAX_VEC_COMPONENTS ); // initialize the array with random numbers + FILL_FLOAT_ARRAY_LIMIT( esp_buf[1], tmp_len * MAX_VEC_COMPONENTS ); // initialize the array with random numbers memcpy( esp_buf[2], esp_buf[0], inbytes ); memcpy( esp_buf[3], esp_buf[1], inbytes ); diff --git a/headers/unit_test_x_operation_x_tolerant.h b/headers/unit_test_x_operation_x_tolerant.h index dfb2489..3632c6a 100644 --- a/headers/unit_test_x_operation_x_tolerant.h +++ b/headers/unit_test_x_operation_x_tolerant.h @@ -54,7 +54,7 @@ arm_float_t * thesrc2 = NULL; arm_float_t * thedst[IMPL_COUNT]; // output from different implementations are stored in separate arrays for varification int done_init = 0; -// Eight buffers that are used for especial test cases such as when the destination and source point to the same address. +// Eight buffers that are used for special test cases such as when the destination and source point to the same address. // They may vary in size from one case to another and from one function to another. arm_float_t* esp_buf[8]; @@ -85,7 +85,7 @@ arm_result_t test_operation() done_init = 1; } - // test the especial case where dst == src + // test the special case where dst == src unsigned int tmp_len = 13; // Just an odd number bigger than 8 unsigned int inbytes = tmp_len * MAX_VEC_COMPONENTS * sizeof(arm_float_t); esp_buf[0] = (arm_float_t*) malloc( inbytes ); // input 1 @@ -94,8 +94,8 @@ arm_result_t test_operation() esp_buf[3] = (arm_float_t*) malloc( inbytes ); // copy of 2nd input esp_buf[4] = (arm_float_t*) malloc( inbytes ); // use this as the output buffer - FILL_FLOAT_ARRAY_LIMIT( esp_buf[0], tmp_len * MAX_VEC_COMPONENTS ); // initialization the array with random numbers - FILL_FLOAT_ARRAY_LIMIT( esp_buf[1], tmp_len * MAX_VEC_COMPONENTS ); // initialization the array with random numbers + FILL_FLOAT_ARRAY_LIMIT( esp_buf[0], tmp_len * MAX_VEC_COMPONENTS ); // initialize the array with random numbers + FILL_FLOAT_ARRAY_LIMIT( esp_buf[1], tmp_len * MAX_VEC_COMPONENTS ); // initialize the array with random numbers memcpy( esp_buf[2], esp_buf[0], inbytes ); memcpy( esp_buf[3], esp_buf[1], inbytes ); diff --git a/headers/unit_test_xc_operation_x.h b/headers/unit_test_xc_operation_x.h index 4885b7c..1a92d70 100644 --- a/headers/unit_test_xc_operation_x.h +++ b/headers/unit_test_xc_operation_x.h @@ -54,7 +54,7 @@ arm_float_t * thesrc = NULL; arm_float_t * thedst[IMPL_COUNT]; // output from different implementations are stored in separate arrays for varification int done_init = 0; -// Eight buffers that are used for especial test cases such as when the destination and source point to the same address. +// Eight buffers that are used for special test cases such as when the destination and source point to the same address. // They may vary in size from one case to another and from one function to another. arm_float_t* esp_buf[8]; @@ -86,7 +86,7 @@ arm_result_t test_operation() } - // test the especial case where dst == src + // test the special case where dst == src unsigned int tmp_len = 13; // Just an odd number bigger than 8 unsigned int inbytes = tmp_len * MAX_VEC_COMPONENTS * sizeof(float); esp_buf[0] = (arm_float_t*) malloc( inbytes ); // input 1 @@ -95,8 +95,8 @@ arm_result_t test_operation() esp_buf[3] = (arm_float_t*) malloc( inbytes ); // copy of 2nd input esp_buf[4] = (arm_float_t*) malloc( inbytes ); // use this as the output buffer - FILL_FLOAT_ARRAY_LIMIT( esp_buf[0], tmp_len * MAX_VEC_COMPONENTS ); // initialization the array with random numbers - FILL_FLOAT_ARRAY_LIMIT( esp_buf[1], tmp_len * MAX_VEC_COMPONENTS ); // initialization the array with random numbers + FILL_FLOAT_ARRAY_LIMIT( esp_buf[0], tmp_len * MAX_VEC_COMPONENTS ); // initialize the array with random numbers + FILL_FLOAT_ARRAY_LIMIT( esp_buf[1], tmp_len * MAX_VEC_COMPONENTS ); // initialize the array with random numbers memcpy( esp_buf[2], esp_buf[0], inbytes ); memcpy( esp_buf[3], esp_buf[1], inbytes ); diff --git a/headers/unit_test_xmat_operation_x.h b/headers/unit_test_xmat_operation_x.h index c1c6bc5..1ef37f2 100644 --- a/headers/unit_test_xmat_operation_x.h +++ b/headers/unit_test_xmat_operation_x.h @@ -55,7 +55,7 @@ arm_float_t * thesrc2 = NULL; arm_float_t * thedst[IMPL_COUNT]; // output from different implementations are stored in separate arrays for varification int done_init = 0; -// Eight buffers that are used for especial test cases such as when the destination and source point to the same address. +// Eight buffers that are used for special test cases such as when the destination and source point to the same address. // They may vary in size from one case to another and from one function to another. arm_float_t* esp_buf[8]; @@ -86,7 +86,7 @@ arm_result_t test_operation() done_init = 1; } - // test the especial case where dst == src + // test the special case where dst == src unsigned int tmp_len = 13; // Just an odd number bigger than 8 unsigned int inbytes = tmp_len * MAX_VEC_COMPONENTS * sizeof(arm_float_t); esp_buf[0] = (arm_float_t*) malloc( inbytes ); // input 1 @@ -95,8 +95,8 @@ arm_result_t test_operation() esp_buf[3] = (arm_float_t*) malloc( inbytes ); // copy of 2nd input esp_buf[4] = (arm_float_t*) malloc( inbytes ); // use this as the output buffer - FILL_FLOAT_ARRAY_LIMIT( esp_buf[0], tmp_len * MAX_VEC_COMPONENTS ); // initialization the array with random numbers - FILL_FLOAT_ARRAY_LIMIT( esp_buf[1], tmp_len * MAX_VEC_COMPONENTS ); // initialization the array with random numbers + FILL_FLOAT_ARRAY_LIMIT( esp_buf[0], tmp_len * MAX_VEC_COMPONENTS ); // initialize the array with random numbers + FILL_FLOAT_ARRAY_LIMIT( esp_buf[1], tmp_len * MAX_VEC_COMPONENTS ); // initialize the array with random numbers memcpy( esp_buf[2], esp_buf[0], inbytes ); memcpy( esp_buf[3], esp_buf[1], inbytes );