From: Masahisa Kojima <masahisa.kojima@linaro.org>
Date: Thu, 2 Feb 2023 09:24:45 +0000 (+0900)
Subject: eficonfig: set EFICONFIG_ENTRY_NUM_MAX to INT_MAX - 1
X-Git-Tag: v2023.07~161^2~15
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1f0583beeb32b0eab4d87ea9c0bef247432aa0c6;p=platform%2Fkernel%2Fu-boot.git

eficonfig: set EFICONFIG_ENTRY_NUM_MAX to INT_MAX - 1

eficonfig_append_menu_entryi() accepts the number of entries
less than or equal to EFICONFIG_ENTRY_NUM_MAX.
EFICONFIG_ENTRY_NUM_MAX is currently set as INT_MAX, so
the invalid menu count check(efi_menu->count > EFICONFIG_ENTRY_NUM_MAX)
in eficonfig_process_common() is always false.

This commit sets EFICONFIG_ENTRY_NUM_MAX to (INT_MAX - 1).

Reported-by: Coverity (CID 435659)
Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>
Reviewed-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---

diff --git a/include/efi_config.h b/include/efi_config.h
index e5edbb5..01ce9b2 100644
--- a/include/efi_config.h
+++ b/include/efi_config.h
@@ -11,7 +11,7 @@
 #include <efi_loader.h>
 #include <menu.h>
 
-#define EFICONFIG_ENTRY_NUM_MAX INT_MAX
+#define EFICONFIG_ENTRY_NUM_MAX (INT_MAX - 1)
 #define EFICONFIG_VOLUME_PATH_MAX 512
 #define EFICONFIG_FILE_PATH_MAX 512
 #define EFICONFIG_FILE_PATH_BUF_SIZE (EFICONFIG_FILE_PATH_MAX * sizeof(u16))