From: Lukasz Oleksak <l.oleksak@samsung.com>
Date: Wed, 14 Dec 2022 13:34:20 +0000 (+0100)
Subject: [ATSPI] Lazily embed the web content subtree
X-Git-Tag: accepted/tizen/7.0/unified/20230103.164452~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1f01d1789c381b621845708f46d382e242a9256b;p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git

[ATSPI] Lazily embed the web content subtree

Delays necessity to make synchronous call on dbus, what reduces chances
for deadlock.

Change-Id: Ica669ca490619ca0906cc0c14c8f7dfde0925023
(cherry picked from commit 08137e93e1cab00962a917ac193d815be78eecca)
---

diff --git a/dali-toolkit/internal/controls/web-view/web-view-impl.cpp b/dali-toolkit/internal/controls/web-view/web-view-impl.cpp
index 68aec5e348..ded91c5383 100755
--- a/dali-toolkit/internal/controls/web-view/web-view-impl.cpp
+++ b/dali-toolkit/internal/controls/web-view/web-view-impl.cpp
@@ -1304,6 +1304,9 @@ void WebView::WebViewAccessible::DoGetChildren(std::vector<Dali::Accessibility::
 {
   if(mRemoteChild.GetAddress())
   {
+    // DoGetChildren is called at most once per every OnChildrenChanged.
+    // We have only one OnChildrenChanged in this case, so EmbedAtkSocket will be called only once.
+    Accessibility::Bridge::GetCurrentBridge()->EmbedAtkSocket(GetAddress(), mRemoteChild.GetAddress());
     children.push_back(&mRemoteChild);
   }
 }
@@ -1334,11 +1337,6 @@ void WebView::WebViewAccessible::SetRemoteChildAddress(Dali::Accessibility::Addr
 {
   mRemoteChild.SetAddress(address);
   OnChildrenChanged();
-
-  if(address)
-  {
-    Accessibility::Bridge::GetCurrentBridge()->EmbedAtkSocket(GetAddress(), address);
-  }
 }
 
 #undef GET_ENUM_STRING