From: Heechul Jeon Date: Mon, 21 Aug 2017 07:25:18 +0000 (+0900) Subject: remove unnecessary comment & codes X-Git-Tag: submit/tizen/20170822.114338~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1ef2435ae23d80bbe369dbed3e0eadc3614888fc;p=platform%2Fcore%2Fmultimedia%2Flibmm-player.git remove unnecessary comment & codes Change-Id: Ib1e96067e804b7cac3e2cf08f420b0b9ff83c967 --- diff --git a/src/mm_player_es.c b/src/mm_player_es.c index a6f2b7b..c9df062 100644 --- a/src/mm_player_es.c +++ b/src/mm_player_es.c @@ -195,9 +195,6 @@ _mmplayer_set_media_stream_buffer_status_cb(MMHandleType hplayer, MMPLAYER_RETURN_VAL_IF_FAIL(player, MM_ERROR_PLAYER_NOT_INITIALIZED); - if ((type < MM_PLAYER_STREAM_TYPE_DEFAULT) || (type > MM_PLAYER_STREAM_TYPE_TEXT)) - return MM_ERROR_INVALID_ARGUMENT; - MMPLAYER_MEDIA_STREAM_CALLBACK_LOCK(player); if (player->media_stream_buffer_status_cb[type]) { @@ -231,8 +228,6 @@ _mmplayer_set_media_stream_seek_data_cb(MMHandleType hplayer, MMPLAYER_RETURN_VAL_IF_FAIL(player, MM_ERROR_PLAYER_NOT_INITIALIZED); - if ((type < MM_PLAYER_STREAM_TYPE_DEFAULT) || (type > MM_PLAYER_STREAM_TYPE_TEXT)) - return MM_ERROR_INVALID_ARGUMENT; MMPLAYER_MEDIA_STREAM_CALLBACK_LOCK(player); if (player->media_stream_seek_data_cb[type]) { @@ -318,9 +313,6 @@ _mmplayer_get_media_stream_max_size(MMHandleType hplayer, MMPlayerStreamType typ MMPLAYER_RETURN_VAL_IF_FAIL(player, MM_ERROR_PLAYER_NOT_INITIALIZED); MMPLAYER_RETURN_VAL_IF_FAIL(max_size, MM_ERROR_INVALID_ARGUMENT); - if ((type < MM_PLAYER_STREAM_TYPE_DEFAULT) || (type > MM_PLAYER_STREAM_TYPE_TEXT)) - return MM_ERROR_INVALID_ARGUMENT; - *max_size = player->media_stream_buffer_max_size[type]; MMPLAYER_FLEAVE(); @@ -366,9 +358,6 @@ _mmplayer_get_media_stream_min_percent(MMHandleType hplayer, MMPlayerStreamType MMPLAYER_RETURN_VAL_IF_FAIL(player, MM_ERROR_PLAYER_NOT_INITIALIZED); MMPLAYER_RETURN_VAL_IF_FAIL(min_percent, MM_ERROR_INVALID_ARGUMENT); - if ((type < MM_PLAYER_STREAM_TYPE_DEFAULT) || (type > MM_PLAYER_STREAM_TYPE_TEXT)) - return MM_ERROR_INVALID_ARGUMENT; - *min_percent = player->media_stream_buffer_min_percent[type]; MMPLAYER_FLEAVE(); diff --git a/src/mm_player_priv.c b/src/mm_player_priv.c index 43bcc2b..ee4a122 100644 --- a/src/mm_player_priv.c +++ b/src/mm_player_priv.c @@ -609,11 +609,6 @@ __mmplayer_set_state(mm_player_t* player, int state) MMPLAYER_PREV_STATE(player) = MMPLAYER_CURRENT_STATE(player); MMPLAYER_CURRENT_STATE(player) = state; - /* FIXIT : it's better to do like below code - if (MMPLAYER_CURRENT_STATE(player) == MMPLAYER_TARGET_STATE(player)) - MMPLAYER_PENDING_STATE(player) = MM_PLAYER_STATE_NONE; - and add more code to handling PENDING_STATE. - */ if (MMPLAYER_CURRENT_STATE(player) == MMPLAYER_PENDING_STATE(player)) MMPLAYER_PENDING_STATE(player) = MM_PLAYER_STATE_NONE;