From: tommyadam <tommyadam@freenet.de>
Date: Wed, 3 Jul 2013 08:22:50 +0000 (+0200)
Subject: Fix resource leak in directshow plugin.
X-Git-Tag: upstream/5.2.95+rc1~69^2~4
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1eb77d37821a42742a9b2984c89e3aed8296a5fc;p=platform%2Fupstream%2Fqtmultimedia.git

Fix resource leak in directshow plugin.

Add two missing release calls to free file handles.

Task-number: QTBUG-23822
Change-Id: I8f5b6d0dcf9ad66bdaa2f378c0d3e401388d7add
Reviewed-by: Wouter Huysentruit <wouter.huysentruit@dzine.be>
Reviewed-by: Yoann Lopes <yoann.lopes@digia.com>
---

diff --git a/src/plugins/directshow/player/directshowplayerservice.cpp b/src/plugins/directshow/player/directshowplayerservice.cpp
index d89ed7b..70049e2 100644
--- a/src/plugins/directshow/player/directshowplayerservice.cpp
+++ b/src/plugins/directshow/player/directshowplayerservice.cpp
@@ -578,6 +578,9 @@ void DirectShowPlayerService::doReleaseGraph(QMutexLocker *locker)
         control->Release();
     }
 
+    //release m_headerInfo -> decrease ref counter of m_source
+    m_metaDataControl->updateGraph(0, 0);
+
     if (m_source) {
         m_source->Release();
         m_source = 0;
@@ -627,6 +630,7 @@ int DirectShowPlayerService::findStreamTypes(IBaseFilter *source) const
                     }
                 }
             }
+            pins->Release();
         }
         filter->Release();
     }