From: Jan Kara Date: Fri, 23 Jun 2017 22:08:46 +0000 (-0700) Subject: fs/dax.c: fix inefficiency in dax_writeback_mapping_range() X-Git-Tag: v4.14-rc1~695^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1eb643d02b21412e603b42cdd96010a2ac31c05f;p=platform%2Fkernel%2Flinux-rpi.git fs/dax.c: fix inefficiency in dax_writeback_mapping_range() dax_writeback_mapping_range() fails to update iteration index when searching radix tree for entries needing cache flushing. Thus each pagevec worth of entries is searched starting from the start which is inefficient and prone to livelocks. Update index properly. Link: http://lkml.kernel.org/r/20170619124531.21491-1-jack@suse.cz Fixes: 9973c98ecfda3 ("dax: add support for fsync/sync") Signed-off-by: Jan Kara Reviewed-by: Ross Zwisler Cc: Dan Williams Cc: Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/fs/dax.c b/fs/dax.c index 2a6889b..9187f3b 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -859,6 +859,7 @@ int dax_writeback_mapping_range(struct address_space *mapping, if (ret < 0) goto out; } + start_index = indices[pvec.nr - 1] + 1; } out: put_dax(dax_dev);