From: Randeep Singh <randeep.s@samsung.com>
Date: Thu, 22 Sep 2016 05:32:02 +0000 (+0530)
Subject: [IOT-1319] Resolved potential buffer overflow case
X-Git-Tag: 1.3.0~1057^2~95
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1eaa05e4bb9c3b18087f908dfb88f37514091eac;p=platform%2Fupstream%2Fiotivity.git

[IOT-1319] Resolved potential buffer overflow case

Change-Id: Ic5779a529085514a9269321c60770cd13c8fcd25
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12137
Reviewed-by: Greg Zaverucha <gregz@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini  Kumar <k.ashwini@samsung.com>
---

diff --git a/resource/csdk/security/src/policyengine.c b/resource/csdk/security/src/policyengine.c
index 3dd424d..fd9f2ed 100644
--- a/resource/csdk/security/src/policyengine.c
+++ b/resource/csdk/security/src/policyengine.c
@@ -300,12 +300,10 @@ static void CopyParamsToContext(PEContext_t     *context,
     memcpy(&context->subject, subjectId, sizeof(OicUuid_t));
 
     // Copy the resource string into context.
-    length = strlen(resource) + 1;
-    if (0 < length)
-    {
-        strncpy(context->resource, resource, length);
-        context->resource[length - 1] = '\0';
-    }
+    length = sizeof(context->resource) - 1;
+    strncpy(context->resource, resource, length);
+    context->resource[length] = '\0';
+
 
     // Assign the permission field.
     context->permission = requestedPermission;