From: tangwenji <tang.wenji@zte.com.cn>
Date: Wed, 13 Mar 2019 14:56:38 +0000 (+0800)
Subject: scsi: target: iscsi: Fix np_ip_proto and np_sock_type in iscsit_setup_np
X-Git-Tag: v5.15~6074^2~231
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1ea9b4633cda461f09b4476ff612d32d78e81c92;p=platform%2Fkernel%2Flinux-starfive.git

scsi: target: iscsi: Fix np_ip_proto and np_sock_type in iscsit_setup_np

In the switch, np_ip_proto and np_sock_type set different values according
to np_network_transport, and then uniformly assign values, so the previous
values are overwritten.

Signed-off-by: tangwenji <tang.wenji@zte.com.cn>
Reviewed-by: Mike Christie <mchristi@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
---

diff --git a/drivers/target/iscsi/iscsi_target_login.c b/drivers/target/iscsi/iscsi_target_login.c
index ae3209efd0e0..c526e665f022 100644
--- a/drivers/target/iscsi/iscsi_target_login.c
+++ b/drivers/target/iscsi/iscsi_target_login.c
@@ -883,9 +883,6 @@ int iscsit_setup_np(
 		return -EINVAL;
 	}
 
-	np->np_ip_proto = IPPROTO_TCP;
-	np->np_sock_type = SOCK_STREAM;
-
 	ret = sock_create(sockaddr->ss_family, np->np_sock_type,
 			np->np_ip_proto, &sock);
 	if (ret < 0) {