From: yosin@chromium.org Date: Thu, 5 Jul 2012 03:48:03 +0000 (+0000) Subject: [Tools] webkit_unittest.py got assertion X-Git-Tag: 070512121124~20 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1ea13e6d99f1b9363e29c7ce30e44b8f03930f78;p=profile%2Fivi%2Fwebkit-efl.git [Tools] webkit_unittest.py got assertion https://bugs.webkit.org/show_bug.cgi?id=90579 Reviewed by Hajime Morita. This patch updates expectation of assertion in test_skipped_directories_for_symbols(). r121874 added new (exclude) directory (inspector/styles/variables), however it didn't update one of two assertions. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121878 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- diff --git a/Tools/ChangeLog b/Tools/ChangeLog index f2156f7..ab6d6d0 100644 --- a/Tools/ChangeLog +++ b/Tools/ChangeLog @@ -1,3 +1,16 @@ +2012-07-04 Yoshifumi Inoue + + [Tools] webkit_unittest.py got assertion + https://bugs.webkit.org/show_bug.cgi?id=90579 + + Reviewed by Hajime Morita. + + This patch updates expectation of assertion in test_skipped_directories_for_symbols(). + r121874 added new (exclude) directory (inspector/styles/variables), however it didn't + update one of two assertions. + + * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: + 2012-07-04 Balazs Ankes webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing diff --git a/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py b/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py index 6b45d42..cfec29b 100755 --- a/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py +++ b/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py @@ -113,7 +113,7 @@ class WebKitPortTest(port_testcase.PortTestCase): 000000000124f670 s __ZZN7WebCore13GraphicsLayer13addChildBelowEPS0_S1_E19__PRETTY_FUNCTION__ """ # Note 'compositing' is not in the list of skipped directories (hence the parsing of GraphicsLayer worked): - expected_directories = set(['mathml', 'transforms/3d', 'compositing/webgl', 'fast/canvas/webgl', 'animations/3d', 'mhtml', 'http/tests/canvas/webgl', 'fast/css/variables']) + expected_directories = set(['mathml', 'transforms/3d', 'compositing/webgl', 'fast/canvas/webgl', 'animations/3d', 'mhtml', 'http/tests/canvas/webgl', 'fast/css/variables', 'inspector/styles/variables']) result_directories = set(TestWebKitPort(symbols_string, None)._skipped_tests_for_unsupported_features(test_list=['mathml/foo.html'])) self.assertEqual(result_directories, expected_directories)