From: H Hartley Sweeten Date: Thu, 4 Sep 2014 17:39:39 +0000 (-0700) Subject: staging: comedi: adl_pci9118: tidy up digital output subdevice init X-Git-Tag: v4.14-rc1~6739^2~690 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1e9879f7a443d9bd06dd40544c1b91766008b880;p=platform%2Fkernel%2Flinux-rpi.git staging: comedi: adl_pci9118: tidy up digital output subdevice init For aesthetics, add some whitespace to the digital output subdevice init. Remove the SDF_GROUND and SDF_COMMON subdev_flags. These flags only apply to analog subdevices. Remove the 'len_chanlist' init, this subdevice member is only used with subdevices that support async commands. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118.c index 8b086c2..d7af6f7 100644 --- a/drivers/staging/comedi/drivers/adl_pci9118.c +++ b/drivers/staging/comedi/drivers/adl_pci9118.c @@ -1907,14 +1907,14 @@ static int pci9118_common_attach(struct comedi_device *dev, int disable_irq, s->range_table = &range_digital; s->insn_bits = pci9118_insn_bits_di; + /* Digital Output subdevice */ s = &dev->subdevices[3]; - s->type = COMEDI_SUBD_DO; - s->subdev_flags = SDF_WRITABLE | SDF_GROUND | SDF_COMMON; - s->n_chan = 4; - s->maxdata = 1; - s->len_chanlist = 4; - s->range_table = &range_digital; - s->insn_bits = pci9118_insn_bits_do; + s->type = COMEDI_SUBD_DO; + s->subdev_flags = SDF_WRITABLE; + s->n_chan = 4; + s->maxdata = 1; + s->range_table = &range_digital; + s->insn_bits = pci9118_insn_bits_do; devpriv->ai_maskharderr = 0x10a; /* default measure crash condition */