From: Jaegeuk Kim Date: Thu, 2 Jun 2016 21:15:56 +0000 (-0700) Subject: f2fs: avoid data race between FI_DIRTY_INODE flag and update_inode X-Git-Tag: v4.14-rc1~2821^2~44 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1e7c48fa9a34556639328d50780d12a304e0bb6d;p=platform%2Fkernel%2Flinux-rpi.git f2fs: avoid data race between FI_DIRTY_INODE flag and update_inode FI_DIRTY_INODE flag is not covered by inode page lock, so it can be unset at any time like below. Thread #1 Thread #2 - lock_page(ipage) - update i_fields - update i_size/i_blocks/and so on - set FI_DIRTY_INODE - reset FI_DIRTY_INODE - set_page_dirty(ipage) In this case, we can lose the latest i_field information. Signed-off-by: Jaegeuk Kim --- diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index fb3d9bd..63c4326 100644 --- a/fs/f2fs/inode.c +++ b/fs/f2fs/inode.c @@ -231,6 +231,8 @@ int update_inode(struct inode *inode, struct page *node_page) { struct f2fs_inode *ri; + f2fs_inode_synced(inode); + f2fs_wait_on_page_writeback(node_page, NODE, true); ri = F2FS_INODE(node_page); @@ -265,7 +267,6 @@ int update_inode(struct inode *inode, struct page *node_page) __set_inode_rdev(inode, ri); set_cold_node(inode, node_page); - f2fs_inode_synced(inode); /* deleted inode */ if (inode->i_nlink == 0)