From: Simon Glass Date: Mon, 11 Mar 2013 06:08:13 +0000 (+0000) Subject: sf: Use unsigned type for buffers X-Git-Tag: v2013.04-rc2~22^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1e7133e99e27c4f02998e7eb87fa43424d48152b;p=platform%2Fkernel%2Fu-boot.git sf: Use unsigned type for buffers The verify code is broken on archs with signed char. Fix it. Signed-off-by: Simon Glass --- diff --git a/common/cmd_sf.c b/common/cmd_sf.c index b175358..3f0d414 100644 --- a/common/cmd_sf.c +++ b/common/cmd_sf.c @@ -369,8 +369,8 @@ static void spi_test_next_stage(struct test_info *test) * @param vbuf Verification buffer * @return 0 if ok, -1 on error */ -static int spi_flash_test(struct spi_flash *flash, char *buf, ulong len, - ulong offset, char *vbuf) +static int spi_flash_test(struct spi_flash *flash, uint8_t *buf, ulong len, + ulong offset, uint8_t *vbuf) { struct test_info test; int i; @@ -431,9 +431,9 @@ static int do_spi_flash_test(int argc, char * const argv[]) { unsigned long offset; unsigned long len; - char *buf = (char *)CONFIG_SYS_TEXT_BASE; + uint8_t *buf = (uint8_t *)CONFIG_SYS_TEXT_BASE; char *endp; - char *vbuf; + uint8_t *vbuf; int ret; offset = simple_strtoul(argv[1], &endp, 16);