From: Jonas Devlieghere <jonas@devlieghere.com>
Date: Wed, 14 Jul 2021 20:21:36 +0000 (-0700)
Subject: [lldb] Always call DestroyImpl from Process::Finalize
X-Git-Tag: llvmorg-14-init~1458
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1e4a417ee639b867b783e52949d22c1965ab25d0;p=platform%2Fupstream%2Fllvm.git

[lldb] Always call DestroyImpl from Process::Finalize

Always destroy the process, regardless of its private state. This will
call the virtual function DoDestroy under the hood, giving our derived
class a chance to do the necessary tear down, including what to do when
the private state is eStateExited.

Differential revision: https://reviews.llvm.org/D106004
---

diff --git a/lldb/source/Target/Process.cpp b/lldb/source/Target/Process.cpp
index 99e4314..a169b46 100644
--- a/lldb/source/Target/Process.cpp
+++ b/lldb/source/Target/Process.cpp
@@ -493,25 +493,9 @@ void Process::Finalize() {
   if (m_finalizing.exchange(true))
     return;
 
-  // Destroy this process if needed
-  switch (GetPrivateState()) {
-  case eStateConnected:
-  case eStateAttaching:
-  case eStateLaunching:
-  case eStateStopped:
-  case eStateRunning:
-  case eStateStepping:
-  case eStateCrashed:
-  case eStateSuspended:
-    DestroyImpl(false);
-    break;
-
-  case eStateInvalid:
-  case eStateUnloaded:
-  case eStateDetached:
-  case eStateExited:
-    break;
-  }
+  // Destroy the process. This will call the virtual function DoDestroy under
+  // the hood, giving our derived class a chance to do the ncessary tear down.
+  DestroyImpl(false);
 
   // Clear our broadcaster before we proceed with destroying
   Broadcaster::Clear();