From: David Howells Date: Fri, 6 Aug 2010 15:08:27 +0000 (+0100) Subject: KEYS: request_key() should return -ENOKEY if the constructed key is negative X-Git-Tag: v3.0~4118 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1e456a124353a753e9d1fadfbf5cd459c2f197ae;p=platform%2Fkernel%2Flinux-amlogic.git KEYS: request_key() should return -ENOKEY if the constructed key is negative request_key() should return -ENOKEY if the key it constructs has been negatively instantiated. Without this, request_key() can return an unusable key to its caller, and if the caller then does key_validate() that won't catch the problem. Signed-off-by: David Howells Signed-off-by: Linus Torvalds --- diff --git a/security/keys/request_key.c b/security/keys/request_key.c index 0d26f68..0088dd8 100644 --- a/security/keys/request_key.c +++ b/security/keys/request_key.c @@ -537,6 +537,8 @@ int wait_for_key_construction(struct key *key, bool intr) intr ? TASK_INTERRUPTIBLE : TASK_UNINTERRUPTIBLE); if (ret < 0) return ret; + if (test_bit(KEY_FLAG_NEGATIVE, &key->flags)) + return -ENOKEY; return key_validate(key); } EXPORT_SYMBOL(wait_for_key_construction);