From: Geoff Kizer Date: Wed, 24 Jul 2019 07:47:35 +0000 (-0700) Subject: address review feedback and fix test issue X-Git-Tag: submit/tizen/20210909.063632~11031^2~860^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1e37ef09c1a7b23cbcb92bc6c3822d2091d1342c;p=platform%2Fupstream%2Fdotnet%2Fruntime.git address review feedback and fix test issue Commit migrated from https://github.com/dotnet/corefx/commit/d6e6f52c928f56b424b08fcf6e08ea84a74748ab --- diff --git a/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Connection.cs b/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Connection.cs index c95fdc9..429d29e 100644 --- a/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Connection.cs +++ b/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Connection.cs @@ -758,7 +758,7 @@ namespace System.Net.Http // We can't validate that we hold the semaphore, but we can at least validate that someone is holding it. Debug.Assert(_writerLock.CurrentCount == 0); - EndWrite(false); + EndWrite(forceFlush: false); } private void EndWrite(bool forceFlush) diff --git a/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http2.cs b/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http2.cs index 93782cf..154efba 100644 --- a/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http2.cs +++ b/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http2.cs @@ -2687,8 +2687,6 @@ namespace System.Net.Http.Functional.Tests // We should not reach retry limit without failing. Assert.NotEqual(0, maxCount); - var headers = new HttpHeaderData[] { new HttpHeaderData("x-last", "done") }; - await connection.SendResponseHeadersAsync(streamId, endStream: true, isTrailingHeader : true, headers: headers); try { await connection.SendGoAway(streamId);