From: Mogens Lauridsen Date: Thu, 3 Aug 2017 13:34:12 +0000 (+0200) Subject: crypto: sahara - Fix dma unmap direction X-Git-Tag: v5.15~10515^2~15 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1e3204104cf7f608e90bc824523aaa8129ea944a;p=platform%2Fkernel%2Flinux-starfive.git crypto: sahara - Fix dma unmap direction The direction used in dma_unmap_sg in aes calc is wrong. This result in the cache not being invalidated correct when aes calculation is done and result has been dma'ed to memory. This is seen as sporadic wrong result from aes calc. Signed-off-by: Mogens Lauridsen Signed-off-by: Herbert Xu --- diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c index c2174ec..474da36 100644 --- a/drivers/crypto/sahara.c +++ b/drivers/crypto/sahara.c @@ -543,10 +543,10 @@ static int sahara_hw_descriptor_create(struct sahara_dev *dev) unmap_out: dma_unmap_sg(dev->device, dev->out_sg, dev->nb_out_sg, - DMA_TO_DEVICE); + DMA_FROM_DEVICE); unmap_in: dma_unmap_sg(dev->device, dev->in_sg, dev->nb_in_sg, - DMA_FROM_DEVICE); + DMA_TO_DEVICE); return -EINVAL; } @@ -594,9 +594,9 @@ static int sahara_aes_process(struct ablkcipher_request *req) } dma_unmap_sg(dev->device, dev->out_sg, dev->nb_out_sg, - DMA_TO_DEVICE); - dma_unmap_sg(dev->device, dev->in_sg, dev->nb_in_sg, DMA_FROM_DEVICE); + dma_unmap_sg(dev->device, dev->in_sg, dev->nb_in_sg, + DMA_TO_DEVICE); return 0; }