From: Mikulas Patocka Date: Tue, 7 Jan 2014 03:53:28 +0000 (-0500) Subject: dm: remove pointless kobject comparison in dm_get_from_kobject X-Git-Tag: upstream/snapshot3+hdmi~3608^2~14 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=1ddd641ddcfa46d719189468b6856e9b17381a61;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git dm: remove pointless kobject comparison in dm_get_from_kobject The comparison is always true and the compiler optimizes it out anyway. Milan offered additional context relative to the original commit 784aae735d ("dm: add name and uuid to sysfs") which introduced the code: "I think it is just relict of some experiments before I committed this simple embedded sysfs kobj handling". Signed-off-by: Mikulas Patocka Acked-by: Milan Broz Signed-off-by: Mike Snitzer --- diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 0704c52..b3d9372 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@ -2905,17 +2905,11 @@ struct kobject *dm_kobject(struct mapped_device *md) return &md->kobj; } -/* - * struct mapped_device should not be exported outside of dm.c - * so use this check to verify that kobj is part of md structure - */ struct mapped_device *dm_get_from_kobject(struct kobject *kobj) { struct mapped_device *md; md = container_of(kobj, struct mapped_device, kobj); - if (&md->kobj != kobj) - return NULL; if (test_bit(DMF_FREEING, &md->flags) || dm_deleting_md(md))